? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Mar 2017

Pull Request for #14920

Steps to reproduce the issue

CodeMirror editor (as used in the template editor) has a text string to indicate the keystrokes required to put the editor in full screen mode
screenshotr10-58-34

However there is also an option to add a key modifier eg Shift, Ctrl etc to the Key but there is no code to display the modifier in the string

screenshotr10-58-43

Actual result

Thanks to @C-Lodder

avatar brianteeman brianteeman - open - 29 Mar 2017
avatar brianteeman brianteeman - change - 29 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Mar 2017
Category Administration Language & Strings Front End Plugins
avatar C-Lodder C-Lodder - test_item - 29 Mar 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 29 Mar 2017

I have tested this item successfully on d2f84f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14989.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 29 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Mar 2017

I have tested this item successfully on d2f84f1

Using PR and add iE "Shift" in CodeMirror-Plugin-Settings in Template Editor the Key-Modifier is shown.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14989.

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Mar 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Mar 2017

RTC after two successful testes


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14989.

avatar rdeutz rdeutz - change - 30 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-30 21:41:56
Closed_By rdeutz
Labels Added: ? ?
avatar rdeutz rdeutz - close - 30 Mar 2017
avatar rdeutz rdeutz - merge - 30 Mar 2017
avatar brianteeman
brianteeman - comment - 30 Mar 2017

Thanks

Add a Comment

Login with GitHub to post a comment