Feeling Lucky
?
[#14947] - removed seemingly unneeded &
- Closed
- 16 Aug 2017
- Medium
- Build: staging
- # 14947
- Diff
- N6REJ:blog-item
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
removed extra space and seemingly unnecessary &
Testing Instructions
diff html output with and without &
Expected result
no change.
Actual result
https://www.diffchecker.com/RBOmOouV ( the marked section is literally identical even though it says its not )
if a var_dump is done of the $item compared to & $item and then a diff of that there is no diff at all.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
brianteeman
- comment
- 27 Mar 2017
Wouldnt it also therefore be wrong at line 79 as well?
Quy
- comment
- 10 Apr 2017
Do a search for $this->item = &$item; to find 7 instances. I would change $this->item = & $item; to $this->item = &$item; to match the others.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-16 20:52:12 |
| Closed_By | ⇒ | brianteeman |
@wilsonge I believe you wrote that line?