? ? Pending

User tests: Successful: Unsuccessful:

avatar jreys
jreys
26 Mar 2017

Summary of Changes

Usually when I was using Joomla Admin, the multi-select on the list view was not very user-friendly since clicking on such a small square can sometimes fail on the first try. So I came up with a solution for

Testing Instructions

  • Go to articles (or any multi-select list view), try clicking anywhere on a row, it will select the whole row
  • Try trashing multiple items by clicking severall rows
  • Try the toggle-all button

Expected result

When you click on a row on the articles list view (for example), it will highlight the whole line:
image

When you click on the select-all checkbox, it will highlight all items on that page:
image

Notice

I'm aware of backwards compatibility so the regular checkbox will still work as before while still highlighting the whole line.

avatar jreys jreys - open - 26 Mar 2017
avatar jreys jreys - change - 26 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2017
Category JavaScript
avatar jreys jreys - change - 26 Mar 2017
Title
Improving row selection in Joomla! Admin
[4.0] Improving row selection in Joomla! Admin
avatar jreys jreys - edited - 26 Mar 2017
avatar dgt41
dgt41 - comment - 26 Mar 2017

Can you drop jquery (you don't need it for such easy task) and use a class instead of changing directly the styles

avatar jreys
jreys - comment - 26 Mar 2017

and use a class instead of changing directly the styles

Do you mean adding a class to the row when the action is done?

avatar C-Lodder
C-Lodder - comment - 26 Mar 2017
  • Chain variables
  • No jQuery please
  • Define your colour in the Atum variables.scss
  • Add a class, apply background, call the colour
  • Compile SCSS
  • Use JS (el.classList.toggle('foo');) to toggle the class
avatar jreys jreys - change - 26 Mar 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2017
Category JavaScript Administration Templates (admin) JavaScript
avatar jreys
jreys - comment - 26 Mar 2017
  • Chain variables
  • No jQuery please
  • Define your colour in the Atum variables.scss
  • Add a class, apply background, call the colour
  • Compile SCSS
  • Use JS (element.classList.toggle('foo');) to toggle the class

I have questions on the topics not checked:

  • What do you understand as Chain variables?
  • how do I compile SCSS correctly?
  • the last one seems obvious after SCSS is compiled tbh
avatar dgt41
dgt41 - comment - 27 Mar 2017
"use strict";
var color = '#d9edf7', rows   = document.querySelectorAll('tr[class^="row"]');

The above snippet should take care of the first checkbox.

For compiling SCSS you need to have installed node and npm
Then in the root directory of joomla run npm install
Once complete run grunt compile

avatar C-Lodder
C-Lodder - comment - 27 Mar 2017
avatar jreys
jreys - comment - 27 Mar 2017

I think that is all :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Mar 2017

@jreys is this PR ready to Test?

avatar C-Lodder
C-Lodder - comment - 27 Mar 2017

@jreys - one more thing, please use single quote's as opposed to double quotes where possible.

avatar jreys
jreys - comment - 27 Mar 2017

@franz-wohlkoenig it's ready for testing now, everything fixed

btw @C-Lodder I didn't use the element.classList.toggle('foo'); because it was causing weird behaviours when you selected one row and then selected them all after, it would live the previous row unselected and it's not the wanted behaviour

avatar C-Lodder
C-Lodder - comment - 27 Mar 2017

@jreys - No worries. All seems to be good now.

@dgt41 - JS look ok?

avatar C-Lodder C-Lodder - test_item - 27 Mar 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 27 Mar 2017

I have tested this item successfully on 0a5a387


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14913.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 27 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Mar 2017

I have tested this item successfully on 0a5a387

an optical Feedback like another Curser would help to see that i can move Column.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14913.

avatar jeckodevelopment jeckodevelopment - change - 27 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 27 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14913.

avatar jreys jreys - change - 27 Mar 2017
Labels Added: ?
avatar cokencorn cokencorn - test_item - 28 Mar 2017 - Tested successfully
avatar cokencorn
cokencorn - comment - 28 Mar 2017

I have tested this item successfully on ac8c87d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14913.

avatar wilsonge wilsonge - change - 1 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-01 11:35:53
Closed_By wilsonge
avatar wilsonge wilsonge - close - 1 Apr 2017
avatar wilsonge wilsonge - merge - 1 Apr 2017

Add a Comment

Login with GitHub to post a comment