Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#14911] - [4.0 dev] : added a test to JHighlighter

? ? Pending

User tests: Successful: Unsuccessful:

avatar yasirunilan
yasirunilan
26 Mar 2017

Pull Request for Issue # .

Summary of Changes

Added a javascript test to unhighlight method of JHighlighter library

Testing Instructions

Expected result

Actual result

Code coverage increment

Documentation Changes Required

avatar yasirunilan yasirunilan - open - 26 Mar 2017
avatar yasirunilan yasirunilan - change - 26 Mar 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2017
Category ⇒ JavaScript Unit Tests
avatar C-Lodder
C-Lodder - comment - 27 Mar 2017

Drone tests are failing. You've mispelled the function name.

Change:

highlighter.unhighlights("textarea");

to:

highlighter.unhighlight("textarea");
avatar yvesh
yvesh - comment - 27 Mar 2017

@yasirunilan can you look into this? :-) Thanks

avatar yasirunilan
yasirunilan - comment - 27 Mar 2017

@C-Lodder @yvesh I will look into this and commit again 👍

avatar yasirunilan yasirunilan - change - 27 Mar 2017
Labels Added: ? ?
avatar yasirunilan
yasirunilan - comment - 27 Mar 2017

@C-Lodder this can be merged right?

avatar wilsonge wilsonge - change - 27 Mar 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-03-27 15:32:24
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 27 Mar 2017
avatar wilsonge wilsonge - merge - 27 Mar 2017

Add a Comment

Login with GitHub to post a comment