[#14908] - Remove some no-follow to improve SEO. Fixes #14888
- Closed
- 4 Jan 2018
- Medium
- Build: staging
- # 14908
- Diff
- wilsonge:nofollow
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 0 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #14888 .
Summary of Changes
Removes nofollow attributes in select places
Testing Instructions
Check com_content and com_fields url type no longer have a nofollow attribute
Expected result
Links do not have nofollow
Actual result
Links do have nofollow
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content Plugins Templates (site) |
Simply blindly making this change can in fact harm seo and not improve it
For com_fields, we can add a "rel" attribute. I would also not just remove them.
I have tested this item
just recording an unsuccessful test on this PR on the issue tracker for the reasons stated earlier
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14908.
I am closing this. Two of us have stated that its not a good idea and not b/c, it has conflicts and the OP hasnt responded
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-04 19:23:34 |
| Closed_By | ⇒ | brianteeman |
Simply removing them is not a good idea.
You are changing the behaviour of an existing site. If you really believe
that they are wrong (that's a different debate) then they should be
replaced with an option that the site owner can choose (thats what we do
everywhere else) and for backwards compatibility then they should have a
default value of follow in order not to break an existing site
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On 26 March 2017 at 17:30, George Wilson notifications@github.com wrote:
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/