I think there was a reason the truncateComplex method was added and truncate wasn't made this "smart". But considering how long ago that was, don't ask me why anymore.

whatever it is a bug, I think the first time I have found it was 5 years ago.

I'm just going to go with "meh, whatever, fix it". I tried to find where that was added and all I came up with was a couple of wordy and not really helpful PRs.

I have tested this item ✅ successfully on acb901d

Works.

Before the patch

after the patch

When I add the following unit test data

'HTML allowed, split allowed' => array(
	'<div class="test"><p>whatever it is a bug.</p></div>',
	20,
	true,
	true,
	'<div class="test"><p>whatever</p></div>...',
),

then it fails. As soon as I remove the class="test" code from the div then it works.

<div class="test"><p>whatever it is a bug.</p></div>
1234567890123456789012345678901234567890123456789012
0000000001111111111222222222233333333334444444444555
...................|
<div class="test"><
<div class="test">
<div class="test"></div>

Your split is within the "<p>" Tag, then the "<" will be removed and the div will be closed. So my guess is that your Test result should be

<div class="test"></div>...

Haven't tested it

I have tested this item ✅ successfully on acb901d

Followed Test Instructions #12612 got with or -out PR:

RTC after two successful testes.

I have tested this item ? unsuccessfully on acb901d

Please see my previous comment.

@rdeutz when I remove class="test" from the unit test data, then it shows <div><p>whatever</p></div>.... As far as I understood it, the class attribute should not be counted, or should it?

@laoneo remove RTC?

I would remove it, if Robert thinks my unit test data is invalid and it works as expected, then we can set it back to RTC. But for me it is not fixed for now.

@laoneo, yes you are wrong anything counts.

ups pressed the wrong button

ok, then try this data

'HTML allowed, split allowed' => array(
	'<div class="test"><p>whatever it is a bug.</p></div>',
	25,
	true,
	true,
	'<div class="test"><p>what</p></div>...',
),

it should show <div class="test"><p>what</p></div>... or as it gets splited after 25 charachters?

it gets split and then open tags getting closed, so should be something you wrote, not 100% sure if it is "wha", "what" or "whate"

Unit test does look

ok, I will look into it, does it work without the patch?

same result without the patch

ok, then it is another bug. Can you open an issue for the new bug?

I guess it will be then the same as #11934, just with another unit test data.

I have tested this item ✅ successfully on acb901d

Thanks @rdeutz
Nice work!

RTC

@rdeutz @laoneo do you want to move this to another issue or should this PR be expanded?

As it works for the case @degobbis and me had.

lets merge this one to get one problem solved, I looked into it a bit more and I've found some other issues but because it is unit tested I can work on it later.

I will open a new issue for my other unit test.