? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
25 Mar 2017

Pull Request for Issue #14890 .

Summary of Changes

  • Call the menu function with the right amount of variables
  • Fix all the logic for the modals (since modals they need to be checked against window.parent.Joomla NOT Joomla ). THIS CODE WILL NEVER BE EXECUTED IN 3.x DUE TO THE EXISTENCE of jInsertEditorText(tag, editor);, BUT SINCE IT'S ALREADY FIXED IN J4 THIS ALIGNS THE 2 CODEBASES

Testing Instructions

Inside an article use the menu button to insert a link to a menu item in an article

Expected result

Actual result

Documentation Changes Required

avatar dgt41 dgt41 - open - 25 Mar 2017
avatar dgt41 dgt41 - change - 25 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2017
Category JavaScript
d3e4c00 25 Mar 2017 avatar dgt41 fixes
avatar dgt41 dgt41 - change - 25 Mar 2017
Labels Added: ?
avatar AlexRed AlexRed - test_item - 25 Mar 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 25 Mar 2017

I have tested this item successfully on e70da54

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14902.

b4f0036 25 Mar 2017 avatar dgt41 grrr
avatar infograf768
infograf768 - comment - 25 Mar 2017

will test tomorrow.
First grr solved the language. ;)

avatar dgt41
dgt41 - comment - 25 Mar 2017

@infograf768 I should go back to school and re learn counting from 1 to 6 :)

avatar infograf768 infograf768 - test_item - 26 Mar 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 26 Mar 2017

I have tested this item successfully on 581c0b1

Ok now. (Did not test multiple editors)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14902.

avatar infograf768
infograf768 - comment - 26 Mar 2017

@wilsonge @rdeutz
Please tag to 3.7.0 and release blocker.

avatar brianteeman
brianteeman - comment - 26 Mar 2017

Added release blocker and milestone as requested

avatar wilsonge wilsonge - change - 26 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-26 11:07:39
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 26 Mar 2017
avatar wilsonge wilsonge - merge - 26 Mar 2017

Add a Comment

Login with GitHub to post a comment