User tests: Successful: Unsuccessful:
Pull Request for Issue #14839 .
Added the space between table border and text displayed.Added padding
Go to Menu, Extensions -> Manage -> Discover.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_installer |
This needs to be changed in the scss file, btw. you are doing that against staging (3.7) and not 4.0 branch :-)
We don't do inline styling at all. If you make any styling changes, they MUST go in the SCSS file. Bare in mind the white box also needs some padding.
You'll then need Ruby and NodeJS to lint and compile everything back into CSS. Please read the documentation on how to set everything up properly.
If you want me to do it instead, I'll submit a PR tomorrow.
Thanks for the tips, I'll give it another try. Which scss file do I need to add this styling change?
@yasirunilan - try using a <p>
tag as suggested by Dimitris:
<p><?php echo JText::_('COM_INSTALLER_MSG_DISCOVER_DESCRIPTION'); ?></p>
Ok let me look into it a little later
@yasirunilan I slightly easier solution would be to add class="p-3"
to the following div.. https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/views/discover/tmpl/default.php#L118
Use class="pl-3"
if you just want to add padding to the left.
I made another PR as I had done this PR into staging branch 3.7.
We have another PR #14862 for this issue. So Can anyone close this PR? Thank you.
Closed as requested
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-23 07:58:46 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
|
I added some padding for this. Is it okay or should I create a css class and include it instead of inline styling. Any feedback?