? Pending

User tests: Successful: Unsuccessful:

avatar yasirunilan
yasirunilan
21 Mar 2017

Pull Request for Issue #14839 .

Summary of Changes

Added the space between table border and text displayed.Added padding

Testing Instructions

Go to Menu, Extensions -> Manage -> Discover.

Expected result

101

Actual result

102

Documentation Changes Required

None

avatar yasirunilan yasirunilan - open - 21 Mar 2017
avatar yasirunilan yasirunilan - change - 21 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2017
Category Administration com_installer
avatar yasirunilan
yasirunilan - comment - 21 Mar 2017

I added some padding for this. Is it okay or should I create a css class and include it instead of inline styling. Any feedback?

avatar yvesh
yvesh - comment - 21 Mar 2017

This needs to be changed in the scss file, btw. you are doing that against staging (3.7) and not 4.0 branch :-)

avatar C-Lodder
C-Lodder - comment - 21 Mar 2017

We don't do inline styling at all. If you make any styling changes, they MUST go in the SCSS file. Bare in mind the white box also needs some padding.

You'll then need Ruby and NodeJS to lint and compile everything back into CSS. Please read the documentation on how to set everything up properly.

If you want me to do it instead, I'll submit a PR tomorrow.

avatar yasirunilan
yasirunilan - comment - 22 Mar 2017

Thanks for the tips, I'll give it another try. Which scss file do I need to add this styling change?

avatar C-Lodder
C-Lodder - comment - 22 Mar 2017

@yasirunilan - try using a <p> tag as suggested by Dimitris:

<p><?php echo JText::_('COM_INSTALLER_MSG_DISCOVER_DESCRIPTION'); ?></p>
avatar yasirunilan
yasirunilan - comment - 22 Mar 2017

@C-Lodder I tried it also. Left padding issue is still there.
103

avatar C-Lodder
C-Lodder - comment - 22 Mar 2017

Ok let me look into it a little later

avatar yasirunilan
yasirunilan - comment - 22 Mar 2017

okay @C-Lodder

avatar ciar4n
ciar4n - comment - 22 Mar 2017

@yasirunilan I slightly easier solution would be to add class="p-3" to the following div.. https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_installer/views/discover/tmpl/default.php#L118

Use class="pl-3" if you just want to add padding to the left.

avatar yasirunilan
yasirunilan - comment - 23 Mar 2017

@ciar4n thanks. I made that change and made a PR.

avatar yasirunilan
yasirunilan - comment - 23 Mar 2017

I made another PR as I had done this PR into staging branch 3.7.

avatar RonakParmar
RonakParmar - comment - 23 Mar 2017

We have another PR #14862 for this issue. So Can anyone close this PR? Thank you.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14842.

avatar brianteeman
brianteeman - comment - 23 Mar 2017

Closed as requested

avatar brianteeman brianteeman - change - 23 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-23 07:58:46
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 23 Mar 2017

Add a Comment

Login with GitHub to post a comment