? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
21 Mar 2017

New router for com_newsfeeds and com_contact need new router enabled also in com_content (see #14833)

Simple copy paste error

Shouldnt there be tests for this as well?

avatar brianteeman brianteeman - open - 21 Mar 2017
avatar brianteeman brianteeman - change - 21 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2017
Category Front End com_contact com_newsfeeds com_users
avatar wilsonge
wilsonge - comment - 21 Mar 2017

There's tests for the libraries not the component implementation

avatar wilsonge
wilsonge - comment - 21 Mar 2017

Also newsfeed and contacts can be removed as they are duplicate of first line in function

avatar mbabker
mbabker - comment - 21 Mar 2017

Sooner or later we need to figure out the roadblock that causes us to not write unit tests for code outside the libraries and start writing the tests. Once upon a time system tests were relied for that stuff but there hasn't been a system test suite hooked into core for years. @yvesh here's an indirect task for your team ?

avatar brianteeman brianteeman - change - 21 Mar 2017
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 21 Mar 2017
Category Front End com_contact com_newsfeeds com_users Front End com_contact com_content com_newsfeeds com_users
avatar brianteeman
brianteeman - comment - 21 Mar 2017

duplicates removed from three places

avatar wilsonge wilsonge - change - 21 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-21 19:17:19
Closed_By wilsonge
avatar wilsonge wilsonge - close - 21 Mar 2017
avatar wilsonge wilsonge - merge - 21 Mar 2017
avatar wilsonge
wilsonge - comment - 21 Mar 2017

Merged on review. Now let's see if anything falls out because we never tested the URLs correctly :)

Add a Comment

Login with GitHub to post a comment