Please activate JavaScript in your browser.
?
?
Pending
User tests:
Successful:
Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This is redo of my original PR #14567 because there was some changes to component dispatcher which affected the PR.
This PR contains improvement + clean up to model classes to support both namespace and none namespace components in Joomla 4. See https://github.com/joomdonation/joomla-cms/tree/namespace-com-content/administrator/components/com_content to see namespaced com_content component by @laoneo
Change to Model class
Change getName() method to support detect model name from both namespace class name and none namespace class name
Change getTable() method to allow creating namespace table object
Implement isCheckedOut to allow checking if a record is checked out (use in FormView class in my different PR)
Change to Form Model class
Allow getting xml form and forms field from Model directory
Change to List Model class
Simplify the code of getFilterForm() method
Allow getting xml form and forms field from Model directory
Change to Admin Model class
Use getColumnAlias for check_out field instead of using hardcoded name (make it consistent with other places in our code base)
Testing Instructions
This PR is for code review and discussion for Joomla 4 only. No human testing needed at the moment
joomdonation
-
open
-
20 Mar 2017
joomdonation
-
change
-
20 Mar 2017
joomla-cms-bot
-
change
-
20 Mar 2017
joomdonation
-
change
-
20 Mar 2017
joomla-cms-bot
-
change
-
20 Mar 2017
Category
Libraries
⇒
Libraries
Unit Tests
joomdonation
-
change
-
20 Mar 2017
joomdonation
-
change
-
21 Mar 2017
Status
Pending
⇒
Closed
Closed_Date
0000-00-00 00:00:00
⇒
2017-03-21 14:40:50
Closed_By
⇒
joomdonation
joomdonation
-
close
-
21 Mar 2017
joomdonation
-
change
-
21 Mar 2017
Status
Closed
⇒
New
Closed_Date
2017-03-21 14:40:50
⇒
Closed_By
joomdonation
⇒
joomdonation
-
change
-
21 Mar 2017
joomdonation
-
reopen
-
21 Mar 2017
joomdonation
-
change
-
8 Apr 2017
Status
Pending
⇒
Closed
Closed_Date
0000-00-00 00:00:00
⇒
2017-04-08 10:27:32
Closed_By
⇒
joomdonation
joomdonation
-
close
-
8 Apr 2017
Add a Comment
Login with GitHub to post a comment
Should this pr not be against the 3.8 branch as we need that in the 3 series as well?