[#14772] - Administrator - login page - improove accessiblity
- Closed
- 19 Mar 2017
- Medium
- Build: 4.0-dev
- # 14772
- Diff
- ylahav:4-ydl
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required
The login form was change to be accessible
- screen-reader only labels were added
- colours were changed to get more contrast
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration Templates (admin) |
We need to add the language string for TPL_ATUM_GOTO_JOOMLA_HOME_PAGE :)
I also think any a11y CSS should go into a separate file (a11y.css). I'd then like to add a fixed button in the corner somewhere which when clicked on, adds a class to the body (<body class="a11y">) and all a11y CSS can be done like so:
.a11y .btn-success {
color: #000;
}
i am not in favour of having a separate a11y css OR having a setting to improve a11y. We should be creating an accessible template by default not having an option to be accessible or not. (If nothing else that will lead to the bad old hathor days)
| Labels |
Added:
?
?
|
||
The only accessibility options should be related to how Hathor offered different color styles for different cases (like the high contrast option, also not saying core needs to offer that but just using that example). Otherwise, accessibility is something you bake natively into the UI and markup, it's not an afterthought or an opt-in feature.
+100 lots not repeat the mistakes of the past!!!
@brianteeman - Yup don't worry. We had a chat about it and won't be going down that route
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-19 16:58:52 |
| Closed_By | ⇒ | wilsonge |
@ylahav - you're also missing the label for the 2FA secret key input. Needs to go above this line: https://github.com/ylahav/joomla-cms/blob/1fea828baaf7468c8dfba2d6f0a5ff741f4b7f9c/administrator/modules/mod_login/tmpl/default.php#L66