It is used. It describes the state

It is used. It describes the state

I do not understand that? If you set this option to -1 / Off there is no code which checks that nor makes that sense. If you force https this setting is ignored. And only On makes sense here. Atleast for me.

Don't think about the code. Think about the user interface.

On 19 Mar 2017 12:52 p.m., "zero-24" notifications@github.com wrote:

It is used. It describes the state

I do not understand that? If you set this option to -1 / Off there is no
code which checks that nor makes that sense. If you force https this
setting is ignored. And only On makes sense here. Atleast for me.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#14771 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XHPp24aI-OwoGY1dqbVLhUCukiYks5rnSTzgaJpZM4MhuRa
.

Don't think about the code. Think about the user interface.

Sure but for what reason you want to swich that off?

On => Overrride the global setting wich says "don't force https" if we force HTTPS this setting is ignored. (it is equal)
ignore => use the global settings.
Off => Never works nor can it. If the global setting is forced off this setting is makes no sense.

btw. even if you enabled https just to one page there is (at least for me) no need to set this option Off ;)

It is not about what it does. It's about what it tells the user.

It's about what it tells the user.

It tells the user he switched it off but this don't work?

Show me any other example where you have an On option but do not have an
off.

The solution is not to simply remove the off string.

On 19 Mar 2017 1:19 p.m., "zero-24" notifications@github.com wrote:

It's about what it tells the user.

It tells the user he switched it off but this don't work?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#14771 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eJA6F6k_IKRmiN9z5UscoAO-K0Dks5rnStbgaJpZM4MhuRa
.

I have tested this item ✅ successfully on ebce41a

Patch ok for me. Thanks

I have tested this item ? unsuccessfully on ebce41a

if you upgrade a site which had been saved with -1 aka off
then if you go to the menu item it will be displayed as being on

{"show_title":"1","link_titles":"0","show_intro":"","info_block_position":"","info_block_show_title":"","show_category":"0","link_category":"","show_parent_category":"0","link_parent_category":"","show_associations":"","show_author":"0","link_author":"","show_create_date":"0","show_modify_date":"0","show_publish_date":"0","show_item_navigation":"0","show_vote":"","show_icons":"","show_print_icon":"","show_email_icon":"","show_hits":"0","show_tags":"","show_noauth":"","urls_position":"","menu-anchor_title":"","menu-anchor_css":"","menu_image":"","menu_text":1,"menu_show":1,"page_title":"","show_page_heading":"0","page_heading":"","pageclass_sfx":"","menu-meta_description":"","menu-meta_keywords":"","robots":"","secure":-1}

yes, I confirm the problem after upgrade. Need an if OFF after upgrade --> Ignore

I have a site which has 1 page that can't be https all other pages are set to on apart from this single page set to off, this ensures that any visitor arriving from another page on the site see's the page correctly.
leaving the page set to ignore would mean that going from one https page to this one would cause the page to not load correctly.

For there to be logic here, if Force HTTPS is set to Entire site then showing the option in menus should be hidden and ignored, possibly with a non-changeable state of SECURE/ON/ENABLED if the global setting is set to None or Administrator only the menu option is valid and should be selectable.

I can confirm the problem on Joomla! 3.7.1-dev (nightly Build)

@alexred as its still open then of course nothing has changed.