User tests: Successful: Unsuccessful:
The issue with the SQL field is that it can be risky when none super admins can edit it and define the SQL query setting. This query will be then executed on every article edit or view access. Like that it will be possible to define update queries which can be abused to grant super admin privileges to none super admins.
This PR changes the behavior of the SQL field, that only Super Admins can create it. Additionally it sets the "Edit" permission for all none Super Admin groups to deny. Means the super admin must explicitly allow none super admin groups to edit the field. This is done the way, that the "Public" group has the deny flag, where all (except the super admin) groups will inherit from.
I would like to thank @yvesh and @SniperSister for their help on that.
For the SQL custom field the behavior must be explained in the documentation.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_fields Language & Strings Front End Plugins |
Labels |
Added:
?
?
|
The edit custom field value is only used when editing an article to determine of the field can be changed.
As confirmed with the JSST, this pr should become a release blocker label.
Added release blocker label as requested
Thanks!
I have tested this item
I have tested this item
Works as described
PS: Look like the entered SQL command is not validated on save? The field still being saved even when I enter a wrong SQL command
The SQL error will be catched when the article is edited.
Status | Pending | ⇒ | Ready to Commit |
Labels |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-25 19:49:58 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
?
|
This is locking the Edit permission
Shouldnt we also be locking the Edit Custom Field Value