[#14683] - [com_fields] Reducing drastically the redundant language strings
- Fixed in Code Base
- 18 Mar 2017
- Medium
- Build: staging
- # 14683
- Diff
- infograf768:fields_lang
User tests: Successful: Unsuccessful:
Pull Request for Issue #14677
Summary of Changes
Reducing the number of language strings by using global values.
30 strings are replaced by 8 strings
7 in lib, one in com_fields
Testing Instructions
Enable Language debug
patch and test that fields plugin do not miss any lang values
test that when creating each type of field, we also get all values.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
Would it be wrong to turn COM_FIELDS_FIELD_USE_GLOBAL into JUSE_GLOBAL_FROM_PLUGIN?
JGLOBAL_USE_FROM_PLUGIN then, not JUSE_...
For me it looks wrong to have a com_fields string in a plugin XML file.
It's in the params.xml one used only by com_fields, not in the plugin manifest file. But I understand your point. Personally I could live with it in this specific case.
It's in the params.xml one used only by com_fields
Correctly it is used only by the plugin https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/libraries/fieldsplugin.php#L238 .
I have tested this item
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14683.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-18 11:59:49 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
?
|
||
Would it be wrong to turn COM_FIELDS_FIELD_USE_GLOBAL into JUSE_GLOBAL_FROM_PLUGIN? For me it looks wrong to have a com_fields string in a plugin XML file.