[#14673] - [4.0] Fix installer file input width + other tweaks
- Fixed in Code Base
- 29 Apr 2017
- Medium
- Build: 4.0-dev
- # 14673
- Diff
- C-Lodder:input
User tests: Successful: Unsuccessful:
Pull Request for Issue #14657
Summary of Changes
This PR:
- Fixes the installer file type input width issue so text doesn't overflow
- Replace a couple of instances of jQuery with vanilla JS
- Some styling tweaks
- Replace
<input type="button">with a normal<button> - Fixes the alert cog not directing the user to the options page.
Testing Instructions
- [com_installer] Ensure text doesn't overflow when using long file names
- [com_installer] Go to the Folder tab, type in
http://google.com, clickInstalland ensure the "loading" overlay still appears - [com_installer] Click the cog icon in the alert. This should now direct you to the correct page rather than just close the alert.
- [com_joomlaupdate] Ensure text doesn't overflow when using long file names
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer Front End Plugins |
| Labels |
Added:
?
|
||
| Category | Administration com_installer Front End Plugins | ⇒ | Administration com_installer com_joomlaupdate Front End Plugins |
3:
4:
No, attempt to install a zip file with a long name. The same styling is now being used on both com_installer and com_joomlaupdate so the result will be the same
-
direct to
Upload Package File, but Infotext is cutted:
-
works
If all is correct, i mark "successfully"
That's a different issue. I believe it's BS related, not Joomla
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14673.
| Category | Administration com_installer Front End Plugins com_joomlaupdate | ⇒ | Administration com_installer com_joomlaupdate JavaScript Front End Plugins |
ok i remove my review than .
| Category | Administration com_installer Front End Plugins com_joomlaupdate JavaScript | ⇒ | Administration com_installer com_joomlaupdate JavaScript Language & Strings |
| Labels |
Added:
?
|
||
| Category | Administration com_installer com_joomlaupdate JavaScript Language & Strings | ⇒ | Administration com_installer com_joomlaupdate JavaScript Front End Plugins |
@zero-24 @franz-wohlkoenig all sorted now
yes please
fetching Data in Patchtester got at last 14699.
| Labels |
Removed:
?
|
||
conflicts fixed. There is an error installing an extension (Call to undefined method JInstallerAdapterModule::get()) however this isn't related to the PR
fetching Data in Patchtester stopps at 14799.
@franz-wohlkoenig How comfortable are you with terminal? You can simply fetch this PR using git
uncomfortable. Independent my Comfort: If Testers should test, they need fetching all PR.
Issues with patch tester should be reported on that extension's repo, they don't affect the validity of a PR here (especially as the patch tester isn't actually patching files, which creates a plethora of issues on its own).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14673.
@franz-wohlkoenig - would you mind retesting?
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-29 13:50:07 |
| Closed_By | ⇒ | wilsonge |
@C-Lodder can you create js files instead of the inline script?
Or in another PR