[#14654] - [associations] Plugin link in message
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 14654
- Diff
- brianteeman:plugin-links
User tests: Successful: Unsuccessful:
Summary of Changes
If you go to the Redirects or Smart Search component without the required plugin enabled you will get a message to enable it and the message includes a direct link to the plugin itself.
The new Multilingual Associations component had a similar message but there is no link to the plugin
After applying this PR the message will change to have a link to the plugin in the message itself.
Testing Instructions
Make sure that Items Associations is not enabled in the Language Filter plugin.
Open the Multilingual Associations component
Before the PR the message is just text
After the PR the message includes a link to the Language Filter plugin
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_associations Language & Strings |
| Labels |
Added:
?
?
|
||
@alikon i could do but then the code wouldn't be consistent with the two
other uses. If you think it should be changed i think it would be better to
do it in all three places after this pr in a separate pr
On 16 Mar 2017 9:39 a.m., "Nicola Galgano" notifications@github.com wrote:
@alikon requested changes on this pull request.
In administrator/components/com_associations/helpers/associations.php
#14654 (comment):
- */
- public static function getLanguagefilterPluginId()
- {
$db = JFactory::getDbo();$query = $db->getQuery(true)->select($db->quoteName('extension_id'))->from($db->quoteName('#__extensions'))->where($db->quoteName('folder') . ' = ' . $db->quote('system'))->where($db->quoteName('element') . ' = ' . $db->quote('languagefilter'));$db->setQuery($query);try{$result = (int) $db->loadResult();}catch (RuntimeException $e)can you use proper exception JDatabaseExceptionExecuting instead of
RuntimeException—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14654 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cdD7DAO8SXC1zk9Y3RDi-JHw8Blks5rmQNLgaJpZM4MelfG
.
i've just looked at file diff, and yes can be made on a separate pr
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14654.
@infograf768 I have added the change to the string from the other PR into this one as well to remove merge conflicts and will remove it from that PR too - so that this one can be merged.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14654.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14654.
it is already rtc for 3.7.2
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:54:34 |
| Closed_By | ⇒ | rdeutz |
Thanks
I have tested this item✅ successfully on 194204d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14654.