[#14653] - Tiny JLanguage::loadLanguage() code improvement
- Closed
- 29 Apr 2018
- Medium
- Build: staging
- # 14653
- Diff
- Hackwar:patch-16
User tests: Successful: Unsuccessful:
This simplifies the code slightly. The additional if() is unnecessary. The $strings variable is always defined and the if() does contain nothing else than yet another if(). This change is not really testable and requires a code review.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
The $strings variable is always defined
That's true, but it isn't what is tested there. That check tests if $strings is boolean true, not if it is defined.
The code change itself should be fine, since is_array() will as well return false if $strings is still set to false (a few lines above).
This change is not really testable and requires a code review.
When I look at the code, that change should be testable by deleting/renaming a language file that is supposed to be loaded. If everything works and no errors logged then it is fine.
| Labels |
Added:
?
|
||
Please fix conflicts. Thanks.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-29 19:01:00 |
| Closed_By | ⇒ | Quy |
| Closed_By | Quy | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/14653
See PR #20257
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14653.
I have tested this item✅ successfully on ee0b0a0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14653.