disagree. it does not concern a unique item.

The option is called Item - singular as shown in the screenshot - and that is correct english. There is no option to enable called "items associations"

got it. i think we should rather change it in the plugin, but nevermind

i only care about consistency. if it should be changed in the plugin option instead then i can do that instead but we should use one term. personally i find item associations to be better english than items associations

from ipad
in fact, why don't we simplify to Associations?
the reason why we had Item associations was when we upgraded core to use associations for all core components. it was necessary as the original code in 1.6 only did Menu associations which also was the label value.
Now that history has passed by, Associations (with a correct tip) would be enough imho.

What do you think?

Yes changing to associations only would be good. Will require more changes
in more places but I can do that

On 14 March 2017 at 20:14, infograf768 notifications@github.com wrote:

from ipad
in fact, why don't we simplify to Associations?
the reason why we had Item associations was when we upgraded core to use
associations for all core components. it was necessary as the original code
in 1.6 only did Menu associations which also was the label value.
Now that history has passed by, Associations (with a correct tip) would be
enough imho.

What do you think?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14623 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ZJthk4GGKyNDIEC5LSmwjjMTtSJks5rlvU5gaJpZM4MdAyv
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

So just to be clear you would also change
COM_NEWSFEEDS_ITEM_ASSOCIATIONS_FIELDSET_LABEL="News Feed Item Association"
==>
COM_NEWSFEEDS_ITEM_ASSOCIATIONS_FIELDSET_LABEL="News Feed Association"

COM_MENUS_ITEM_ASSOCIATIONS_FIELDSET_LABEL="Menu Item Associations"
==>
COM_MENUS_ITEM_ASSOCIATIONS_FIELDSET_LABEL="Menu Associations"

no.
i would just change it in the plugin label and in the string value you originally modified here.
only when it can be considered as a general term

ok i will take a look at updating this PR with that tomorrow

I have tested this item ✅ successfully on 371b186

@brianteeman
I checked the strings of type
COM_NEWSFEEDS_ITEM_ASSOCIATIONS_FIELDSET_LABEL

These are only used in Hathor in the sliders.
In fact they are obsolete and could be replaced by
JGLOBAL_FIELDSET_ASSOCIATIONS
in the code. As we do for Isis.
For example where we have
<?php echo JHtml::_('sliders.panel', JText::_('COM_MENUS_ITEM_ASSOCIATIONS_FIELDSET_LABEL'), '-options');?>
line 68 of
/administrator/templates/hathor/html/com_menus/item/edit_options.php

I suggest to do this in another PR. There are 5 instances of them.

en-GB.com_categories.ini:50: COM_CATEGORIES_ITEM_ASSOCIATIONS_FIELDSET_LABEL="Category Item Associations"
en-GB.com_contact.ini:261: COM_CONTACT_ITEM_ASSOCIATIONS_FIELDSET_LABEL="Contact Item Associations"
en-GB.com_content.ini:128: COM_CONTENT_ITEM_ASSOCIATIONS_FIELDSET_LABEL="Content Item Associations"
en-GB.com_menus.ini:71: COM_MENUS_ITEM_ASSOCIATIONS_FIELDSET_LABEL="Menu Item Associations"
en-GB.com_newsfeeds.ini:97: COM_NEWSFEEDS_ITEM_ASSOCIATIONS_FIELDSET_LABEL="News Feed Item Association"

They have equivalent _DESC which are not used and do contain 'Item Associations'. In fact they are more than obsolete and can also be safely deleted.

Concerning this patch, we only need to modify 3 strings values:

PLG_SYSTEM_LANGUAGEFILTER_FIELD_ITEM_ASSOCIATIONS_LABEL="Item Associations"
to
PLG_SYSTEM_LANGUAGEFILTER_FIELD_ITEM_ASSOCIATIONS_LABEL="Associations"

COM_ASSOCIATIONS_ERROR_NO_ASSOC="The Multilingual Associations component can't be used if the site is not set as multilingual and/or Items Associations is not enabled in the Language Filter plugin."
to
COM_ASSOCIATIONS_ERROR_NO_ASSOC="The Multilingual Associations component can't be used if the site is not set as multilingual and/or Associations is not enabled in the Language Filter plugin."

MOD_LANGUAGES_FIELD_CACHING_DESC="Use the global cache setting to cache the content of this module or disable caching for this module.
This should be set to 'No caching' when using Items Associations."
to
MOD_LANGUAGES_FIELD_CACHING_DESC="Use the global cache setting to cache the content of this module or disable caching for this module.
This should be set to 'No caching' when using Associations."

There are a few usage of the term Items Associations in commented code, like
* Method to determine if the language filter Items Associations parameter is enabled.

These are not really important as no impact whatsoever

@brianteeman
Do you mind if I do the second PR?

Go for it. I'm in a meeting this morning. Of course you can't delete the
unused strings because of our policy.

On 15 Mar 2017 9:04 a.m., "infograf768" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman
Do you mind if I do the second PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14623 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8dfCL0RJMGjxlKHOY0f23-3KRujmks5rl6mVgaJpZM4MdAyv
.

PR ready
#14633

@infograf768 thanks - I will update this PR as you commented above when my meeting is over

@infograf768 should be ok now with your suggestions

I have tested this item ✅ successfully on 7b64bc3

OK on review

Removed one string from this Pr in com_associations.ini to avoid conflicts with another Pr #14654

I dont understand why this is saying there are conflicts still. The line it says is in conflict is the line I want to change

conflicts resolved

I have tested this item ✅ successfully on 3514f53

I have tested this item ✅ successfully on 3514f53

RTC after two successful tests.

Thanks