? Pending

User tests: Successful: Unsuccessful:

avatar shivamdiehard
shivamdiehard
14 Mar 2017

Pull Request for Issue #14612

Summary of Changes

Replaced the class="input-xxlarge" with class="input-large"

Testing Instructions

  1. Apply the patch
  2. Go to plugins
  3. Select the TinyMCE plugin
  4. Now the field widths will same as the selects

Before

testbefore

After

test

avatar shivamdiehard shivamdiehard - open - 14 Mar 2017
avatar shivamdiehard shivamdiehard - change - 14 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2017
Category Front End Plugins
avatar shivamdiehard shivamdiehard - change - 14 Mar 2017
The description was changed
avatar shivamdiehard shivamdiehard - edited - 14 Mar 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 14 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Mar 2017

I have tested this item successfully on c68011c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14622.

avatar Fedik
Fedik - comment - 14 Mar 2017

?
that size was made with purpose, no need to change it

avatar JoshuaLewis
JoshuaLewis - comment - 13 May 2017

I have tested this item successfully on c68011c

Works as expected. While generally I like to maximize space usage for certain input fields, it's rare that someone will need beyond 210px of text width. And of course it still works for those who have a lot of text.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14622.

avatar JoshuaLewis JoshuaLewis - test_item - 13 May 2017 - Tested successfully
avatar Fedik
Fedik - comment - 13 May 2017

And of course it still works for those who have a lot of text.

but it will become hard to edit the text in these fields,
that why the width was extended for these particular inputs,
so I am against this changes

avatar ggppdk
ggppdk - comment - 13 May 2017

it's rare that someone will need beyond 210px of text width

rare to input what ?
e.g. parameter for folder path will not fit, and the most relevant part of folder (its ending) will always be hidden, you will need to click and scroll to view / edit it (and changing text-align is not a solution, hiding its start)

e.g. then the 3 "elements" parameters could even be considered to be of "textarea" type,
if we make them smaller it will be quite annoying to edit, unless you copy paste their contents to a text editor and then back to the parameters

let's make it (maybe) a little more beautiful, regardless of usablilty for people that will actually use these parameters
there should be PRs doing the reverse of what this PR does

avatar JoshuaLewis
JoshuaLewis - comment - 13 May 2017

Yeah, wasn't thinking about paths. Valid point. Textareas did come to mind.

avatar franz-wohlkoenig franz-wohlkoenig - change - 14 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 May 2017

RTC after two successful tests.

avatar Fedik
Fedik - comment - 14 May 2017

textarea

the textarea make not much sense, as the code expect "Single line", and in textarea user can think that he can use "new line"

avatar brianteeman
brianteeman - comment - 14 May 2017

Please remove the RTC status - just because it has had two successful tests doesnt mean that the issues that @Fedik raised can be ignored

avatar Bakual
Bakual - comment - 14 May 2017

Imho it doesn't make sense to make the fields smaller beside it looking a bit ugly. So the usuability argument for the CSS file field wins over the design one hands down. Textarea is no option for this field as well.

I'm closing this PR as it will not get merged in this state.

avatar Bakual Bakual - close - 14 May 2017
avatar Bakual Bakual - change - 14 May 2017
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2017-05-14 09:05:01
Closed_By Bakual
Labels Added: ?

Add a Comment

Login with GitHub to post a comment