[#14613] - [4.0] Replace JS Diff script
- Fixed in Code Base
- 18 Mar 2017
- Medium
- Build: 4.0-dev
- # 14613
- Diff
- C-Lodder:diff
User tests: Successful: Unsuccessful:
Pull Request for Issue #14592
Also means #14611 should be merged.
Summary of Changes
This PR introduces a vanilla JS diff script for the content version component, with some HTML5 fixes and other improvements to make the view more simplistic.
Testing Instructions
- Apply PR
- Ensure you have content versioning enabled
- Update any article
- Click "Versions" in the toolbar
- Select 2 articles and click "Compare"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_content com_contenthistory Language & Strings Templates (admin) |
@brianteeman - No. I tried to make the compare a little bit more similar to Github, bu which it shows the original/diff
:(
suppose I can add it back in if you think it beneficial.
Personally I think it is better to have that for the non-developer user. Also the same is true for the ability to compare just the changed values and with and without thew html
You are changing over 130 files? Looks like something is broken?
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
add this
options: {
compress: true,
mangle: false
},before allJs
and for the build script we will do the same but with mangle=true
@brianteeman - re-added the other column.
| Category | JavaScript Administration com_content com_contenthistory Language & Strings Templates (admin) | ⇒ | JavaScript Administration com_content com_contenthistory Language & Strings |
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-18 09:07:53 |
| Closed_By | ⇒ | wilsonge |
do we still have the triple column view?
On 14 March 2017 at 15:33, Lodder notifications@github.com wrote:
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/