Just to put it out there. To stop this list getting too long is it worth having site and admin as the only top level items in the menu's tab and then having the actual menus as a child (as we can't have 3rd level children we'd have to remove the create menu item i guess)

Yes that would be useful especially on multilingual sites with lots of
menus BUT thats a much bigger code task (I think) and would be better to
wait until 3.7+ instead of adding it in at this late stage

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On 13 March 2017 at 14:54, George Wilson notifications@github.com wrote:

Just to put it out there. To stop this list getting too long is it worth
having site and admin as the only top level items in the menu's tab and
then having the actual menus as a child (as we can't have 3rd level
children we'd have to remove the create menu item i guess)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14578 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XQffXdhUeDPLPaF3alyM81kuKczks5rlVivgaJpZM4MbTMb
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@wilsonge it might not make too much sense though on a site with only Site menus

Fair point. This seems like a good step in the right direction tho :)

ofc

Not sure about this change: a module does not display a module

-MOD_MENU_XML_DESCRIPTION="This module displays an administrator menu module."
+MOD_MENU_XML_DESCRIPTION="This module shows the main administrator navigation module."

For Frontend, we use
This module displays a menu on the Frontend.

Suggestion:
MOD_MENU_XML_DESCRIPTION="This module displays a main administrator navigation in the backend."

I used a anyway instead of the as there can be multiple admin menus.

Also, I suggest to bold these new type of separators.
I.e.
use
$this->addChild(new JMenuNode('<strong>' . JText::_('MOD_MENU_MENU_MANAGER_SITE_MENUS') . '</strong>', null, null, false));

and
$this->addChild(new JMenuNode('<strong>' . JText::_('MOD_MENU_MENU_MANAGER_ADMIN_MENUS') . '</strong>', null, null, false));

which gives

This will differentiate with normal menu items

In this case, we could simply use JSITE and JADMINISTRATOR as it is obvious that we are in Menus

Could not find a way for these to not be highlighted, as this is also a bit confusing.

I agree they should be bold - I will update that soon - I was looking for a clever way and didnt find it - didnt think about just using strong

Not sure why I updated the xml description - you are correct that this is wrong. I will update that as well

I found a way to not highlight these new types of separator:

I added:

diff --git a/administrator/modules/mod_menu/menu.php b/administrator/modules/mod_menu/menu.php
index 7233c28..a1fe179 100644
--- a/administrator/modules/mod_menu/menu.php
+++ b/administrator/modules/mod_menu/menu.php
@@ -223,5 +223,9 @@
 		$linkClass = ' class="' . implode(' ', $linkClass) . '"';
 
-		if ($this->_current->link != null && $this->_current->target != null)
+		if ($this->_current->link == null && $this->_current->title =! null)
+		{
+			echo '<span>' . $this->_current->title . '</span>';
+		}
+		elseif ($this->_current->link != null && $this->_current->target != null)
 		{
 			echo '<a' . $linkClass . ' ' . $dataToggle . ' href="' . $this->_current->link . '" target="' . $this->_current->target . '">'

Could someone check if that would have unwanted consequences?

@izharaazmi @zero-24

shall i make a pr towards your branch?

@infograf768 another option would be to create a method similar to

public function addSeparator()

eg public function addSeperatorTitle()

I'd rather add an optional title attribute to the existing separator.

Or maybe just add another level for [All Site Menu Items] > [each as submenu item] and similar for administrator ones.

Both ways are equally appropriate IMO.

If you can do the program then I am all for it

Which one do you prefer, if any?

My preference would be the heading option rather than the submenu as that
will have less impact on a site with few menus

On 14 Mar 2017 9:12 p.m., "Izhar Aazmi" notifications@github.com wrote:

Which one do you prefer, if any?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14578 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Q7bfanuZWBzGOgLA1pkguTrO7x2ks5rlwK4gaJpZM4MbTMb
.

I'll do that. Right now is 3 AM. Good Night folks ?

@izharaazmi did you get anywhere with this?

I'll look at this today.

Please see #15002.

Closing as we have a PR thanks @izharaazmi