[#14577] - Missing translation for the new 'Components menu container' menu item type
- Closed
- 13 Mar 2017
- Medium
- Build: staging
- # 14577
Steps to reproduce the issue
Install an extension such as Virtuemart
Expected result
All values in 'Show or Hide Menu Items' are translated as the standard Joomla admin menu
Actual result
Only item marked as COM_XXX in the XML manifest file are translated, none of the XXX are translated
System information (as much as possible)
In the file root/administrator/components/com_menus/views/item/tmpl/edit_container.php
the language file loading is based in the component name, it should be based on the admin menu item value as for the standard admin menu:
if ($extension = $link->componentname): $lang->load("$extension.sys", JPATH_ADMINISTRATOR, null, false, true) || $lang->load("$extension.sys", JPATH_ADMINISTRATOR . '/components/' . $extension, null, false, true); endif;
Additional comments
joomla-cms-bot
- | Labels |
Added:
?
|
||
Mmmm it looks that i'm no more able to open a pull request for 3.7
Please do that if you know how to, based on the following changes:
File root/administrator/components/com_menus/views/item/tmpl/edit_container.php line 95:
Change from:
if ($extension = $link->componentname):``
to:
if ($extension = $link->element):
File root/administrator/components/com_menus/helpers/menus.php line 184:
Change from:
$query->select('e.name as componentname')
to:
$query->select('e.name as componentname, e.element')
Mmmm it looks that i'm no more able to open a pull request for 3.7
Why do you think so? Just send a PR against staging and you are fine
Looks like you closed the pr?
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-13 16:57:46 |
| Closed_By | ⇒ | joeforjoomla |
@joeforjoomla please send the change as PR than?