? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
13 Mar 2017

Pull Request for Issue #14512 .

Summary of Changes

  • Fix the broken tinymce buttons
  • remove all instances of jInsertEditorText

Testing Instructions

Follow the issue description

Expected result

Actual result

Documentation Changes Required

jInsertEditorText is removed use the API!

There is an error with the media field, but this will be refactored with the new media manager, so...

avatar dgt41 dgt41 - open - 13 Mar 2017
avatar dgt41 dgt41 - change - 13 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2017
Category JavaScript Administration com_fields External Library
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Mar 2017

Same Issue as #14512:
bildschirmfoto 2017-03-13 um 15 01 55

avatar brianteeman
brianteeman - comment - 13 Mar 2017

Looks like this is changing a lot of vendor supplied files ?

avatar dgt41
dgt41 - comment - 13 Mar 2017

@brianteeman it's ok it's just the uglification that was missing

@franz-wohlkoenig which version of tinyMCE are you using legacy or new?

avatar brianteeman
brianteeman - comment - 13 Mar 2017

@dgt41 we still shouldnt be touching vendor files should we? Changes will bee reverted next time the vendor updates

avatar dgt41
dgt41 - comment - 13 Mar 2017

@brianteeman we are not modifying anything, we are creating minified versions of the scripts that don't have one, e.g. codemirror

avatar brianteeman
brianteeman - comment - 13 Mar 2017

@dgt41 well then this is not the PR to do that in. Please keep PR to a single task

avatar dgt41
dgt41 - comment - 13 Mar 2017

@brianteeman this is automated in j4, is one command grunt

avatar brianteeman
brianteeman - comment - 13 Mar 2017

Sorry I missed that you were committing to J4 as you didnt say that anywhere

avatar dgt41 dgt41 - change - 13 Mar 2017
Title
Fix tinyMCE buttons
[4.0] Fix tinyMCE buttons
avatar dgt41 dgt41 - edited - 13 Mar 2017
avatar dgt41 dgt41 - change - 13 Mar 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2017
Category JavaScript Administration com_fields External Library JavaScript Administration com_fields Layout External Library
avatar wilsonge
wilsonge - comment - 14 Mar 2017

Can you fix conflicts dimitris :)

7451f3e 14 Mar 2017 avatar dgt41 fixit
avatar dgt41
dgt41 - comment - 14 Mar 2017

is this repo in sync with current j3 staging?

avatar wilsonge
wilsonge - comment - 14 Mar 2017

As of sunday night it was. there's probably another batch to merge by now

avatar wilsonge wilsonge - change - 18 Mar 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-18 09:19:44
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Mar 2017
avatar wilsonge wilsonge - merge - 18 Mar 2017

Add a Comment

Login with GitHub to post a comment