? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
13 Mar 2017

Pull Request for Issue # .

Summary of Changes

This PR contains improvement + clean up to model classes to support both namespace and none namespace components in Joomla 4 (backward compatible change). Below are the list of changes/improvements:

  1. Change to Model class
  • Change getName() method to support detect model name from both namespace class name and none namespace class name
  • Change getTable() method to allow creating namespace table object
  1. Change to Form Model class
  • Allow getting xml form and forms field from resources directory
  • Note that I want to get rid of using JPATH_COMPONENT, detect folder dynamic from model class name
  1. Change to List Model class
  • Simplify the code of getFilterForm() method
  • Allow getting xml form and forms field from resources directory
  • Note that I want to get rid of using JPATH_COMPONENT, detect folder dynamic from model class name
  1. Change to Admin Model class
  • Use getColumnAlias for check_out field instead of using hardcoded name (make it consistent with other places in our code base)

Testing Instructions

  1. Install Joomla 4.0
  2. Apply patch
  3. Try to navigate to different pages (maybe try to add. edit, delete, publish articles), make sure it is still working as before

I also tested with the namespace com_content component in this PR #14370 and it worked well. Hard for end user to test it for now, thought

Need developers to review code and discuss, too

avatar joomdonation joomdonation - open - 13 Mar 2017
avatar joomdonation joomdonation - change - 13 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2017
Category Libraries
avatar joomdonation joomdonation - change - 13 Mar 2017
Labels Added: ?
avatar joomdonation
joomdonation - comment - 15 Mar 2017

I made change to this PR to get component namespace from manifest cache (same with in the #14511)

Since we haven't had a decision about where to load xml forms and form fields yet, I use the folder resources to make it easy to check it with namespace com_content PR.

Please help review this PR when you have some time

avatar joomla-cms-bot joomla-cms-bot - change - 16 Mar 2017
Category Libraries Libraries Unit Tests
avatar joomdonation joomdonation - change - 19 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-19 08:17:46
Closed_By joomdonation
Labels Added: ?
avatar joomdonation joomdonation - close - 19 Mar 2017

Add a Comment

Login with GitHub to post a comment