? ? Pending

User tests: Successful: 2 franz-wohlkoenig, infograf768 Unsuccessful: 0

avatar ciar4n
ciar4n
13 Mar 2017

Pull Request for Issue #13594 .

Summary of Changes

Stop 'Show User Custom Field' value from been cropped

Testing Instructions

Apply patch and navigate to #Contacts: Edit' -> Tab 'Display' -> Field "Show User Custom Field" Text.

Check input value is not cropped (see #13594)

avatar ciar4n ciar4n - open - 13 Mar 2017
avatar ciar4n ciar4n - change - 13 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2017
Category Administration Templates (admin)
avatar dgt41 dgt41 - test_item - 13 Mar 2017 - Tested successfully
avatar dgt41
dgt41 - comment - 13 Mar 2017

I have tested this item successfully on cc8f1ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 13 Mar 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Mar 2017

I have tested this item ? unsuccessfully on cc8f1ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar ciar4n
ciar4n - comment - 13 Mar 2017

@franz-wohlkoenig Which browsers are you still having this issue?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Mar 2017

@ciar4n Firefox 52.0 (64-bit)

avatar ciar4n
ciar4n - comment - 13 Mar 2017

Strange.. unable to replicate this. Cleared cache and all that?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Mar 2017

Cache cleared, PR de- and reapplied. See 13 Letter more.

avatar tuts-22
tuts-22 - comment - 13 Mar 2017

Can anyone help me here I am not able to apply the patch...
It shows the error:
The file marked for modification does not exist: administrator/templates/isis/less/blocks/_chzn-override.less

avatar zero-24
zero-24 - comment - 13 Mar 2017

@tuts-22 please update to the lst staging and try again. ?

avatar tuts-22
tuts-22 - comment - 13 Mar 2017

@zero-24 Thanks !!

avatar bertmert bertmert - test_item - 13 Mar 2017 - Tested unsuccessfully
avatar bertmert
bertmert - comment - 13 Mar 2017

I have tested this item ? unsuccessfully on cc8f1ba


13-03-_2017_18-56-59

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar ciar4n
ciar4n - comment - 13 Mar 2017

Thank you for testing

@bertmert Could you check if the following is been used.. https://github.com/joomla/joomla-cms/pull/14566/files#diff-64f4e3e067e83c49f7625640e410736fR7032

cropped

avatar brianteeman brianteeman - test_item - 24 Mar 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Mar 2017

I have tested this item successfully on cc8f1ba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Mar 2017

RTC as there are 2 successfully Tests?

avatar ciar4n ciar4n - change - 25 Mar 2017
Labels Added: ?
avatar ciar4n
ciar4n - comment - 25 Mar 2017

Conflicts fixed

avatar infograf768 infograf768 - test_item - 25 Mar 2017 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 25 Mar 2017

I have tested this item ? unsuccessfully on 0e0722f

Does not work on Firefox.

To get it to work, I had to add width:100% !important; in the <li

to

.chzn-container-multi .chzn-choices li.search-field {
margin: 0;
padding: 0;
white-space: nowrap;
width: 100% !important;
}

rather than in

.control-group .chzn-container .chzn-choices .search-field input {
width: 100% !important;
}


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar ciar4n
ciar4n - comment - 25 Mar 2017

Thank you @infograf768

Admittedly I am unable to replicate this issue in FF however I have added the parent li as suggested.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Mar 2017

I have tested this item successfully on a993920


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar infograf768 infograf768 - test_item - 25 Mar 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Mar 2017

I have tested this item successfully on a993920

Works fine now. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar infograf768 infograf768 - change - 25 Mar 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 25 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14566.

avatar wilsonge wilsonge - change - 26 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-26 11:40:12
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 26 Mar 2017
avatar wilsonge wilsonge - merge - 26 Mar 2017

Add a Comment

Login with GitHub to post a comment