? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Mar 2017

Pull Request for Issue #14557 .

avatar brianteeman brianteeman - open - 13 Mar 2017
avatar brianteeman brianteeman - change - 13 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2017
Category Administration Language & Strings
avatar zero-24
zero-24 - comment - 13 Mar 2017

Successfully authenticated to complete the Joomla update.

hmm. If you find this message in your log you have bypassed the token check and authenticated you successfull or not. What about adding this info (bypassed the security checks) to the log?

"Failled to authenticate to complete the Joomla update.

Failled is a typo? Same as above.

Thanks!

avatar brianteeman brianteeman - change - 13 Mar 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 13 Mar 2017

Fixed the typo

I guess I dont understand when you would see this in your logs or what it is supposed to mean.

avatar zero-24
zero-24 - comment - 13 Mar 2017

I guess I dont understand when you would see this in your logs or what it is supposed to mean.

In com_joomlaupdate the JSST implemented a Sec / Token check.

But if we come from a older version the needed token is not added to the URL. So we have implemented a fallback that allows us to pass that check even if we have no token, by a authenticate you as Super User. This message should told you that you are gone that route. (bypass that token check because you are comming from a older version)

avatar mbabker
mbabker - comment - 13 Mar 2017

You're not bypassing the CSRF token check. You've actually failed to match it so you're being prompted to reauthenticate to continue.

avatar zero-24
zero-24 - comment - 13 Mar 2017

Yes. Sorry for my englisch than. This is what i meant.

avatar brianteeman
brianteeman - comment - 13 Mar 2017

Sorry but i am still confused what the string should be

avatar mbabker
mbabker - comment - 13 Mar 2017

Apparently the intent is to log a message if during the update process the CSRF token validation fails and you are required to reauthenticate. The log message is based on the success/fail of that authentication step.

What that means the message should say, I'm still not entirely sure on.

avatar zero-24
zero-24 - comment - 13 Mar 2017

What that means the message should say, I'm still not entirely sure on.

What about the seccond option and just remove it (log + string) if there is no reason to log such event?

avatar mbabker
mbabker - comment - 13 Mar 2017

That works too

avatar zero-24
zero-24 - comment - 13 Mar 2017

see: #14576

avatar brianteeman
brianteeman - comment - 13 Mar 2017

closing as we have decided not to have a message

avatar brianteeman brianteeman - change - 13 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-13 14:14:04
Closed_By brianteeman
avatar brianteeman brianteeman - close - 13 Mar 2017
avatar zero-24
zero-24 - comment - 13 Mar 2017

Thanks @brianteeman

Add a Comment

Login with GitHub to post a comment