This patch is wrong.

1. You did not replace by <?php echo JLayoutHelper::render('joomla.content.language', $item); ?> in modal.php
2. There can't be a content language set to ALL languages or undefined.
3. If we change for the best, we should use hasPopover as I said in the Issue to normalize with the Associations column in the Managers.

I have tested this item ? unsuccessfully on f84e8ce

I have tested this item ? unsuccessfully on 2260cf2

1. fixed - no idea where the modal is used so i cant give test instructions
2. i believe it is correct to check for all possibilities
3. beyond the scope of this PR - this is to fix the current bug

instead of saying it doesnt work it would be really helpful if you said what doesnt work - as it is i am assuming you are just trolling and have muted anything you are saying as its no good for my health or for joomla for you to constantly attack

i believe it is correct to check for all possibilities

These possibilities just do not exist.
A field displaying a formerly existing Content Language (for example in the Language field for an article) which has been deleted can be Undefined.
This is never the case in this component.

There are NO possibility at all to have a content language set to "*"

Code is very explicit.

As for the modal, it is used when changing Target in the side by side view

@brianteeman My PR back then was #12051.
You can make the code even more simpler by removing the flag from the tooltip. It's not really needed and you can remove the whole block which does the "$langImage".

Also, I use "popovers" instead of tooltips

Teh code for categories assoc is here: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_categories/helpers/html/categoriesadministrator.php#L66-L82
You should be able to do something similar.

I did not remove the flag when it is being used as that was a bigger
argument i just didnt want to be a part of. This PR was just to fix the bug
in the current code and nothing more

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On 13 March 2017 at 11:35, Thomas Hunziker notifications@github.com wrote:

@brianteeman https://github.com/brianteeman My PR back then was #12051
#12051.
You can make the code even more simpler by removing the flag from the
tooltip. It's not really needed and you can remove the whole block which
does the "$langImage".
[image: assoc]
https://cloud.githubusercontent.com/assets/1018684/23852609/03a637a4-07e9-11e7-8c86-0e147cd31c61.PNG
Also, I use "popovers" instead of tooltips

Teh code for categories assoc is here: https://github.com/joomla/
joomla-cms/blob/staging/administrator/components/com_
categories/helpers/html/categoriesadministrator.php#L66-L82
You should be able to do something similar.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14563 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8dqzO_2jEsp0LJf9xNuYDJZ9dCAJks5rlSoegaJpZM4MbFoT
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Have made a PR towards your branch with necessary code for boostrap.popover.
brianteeman#3

Once merged we will now get:

I have tested this item ✅ successfully on 1ed7061

Now works fine. Thank you for merging.

I have merged your PR into this one @infograf768

Was this the intended display when there is an association? it looks odd

Looks fine for when there is no association

Do you think perhaps it should say
This item is associated to <<Article>> for this language

Or maybe even

This item is associated in this language to
<<article>>

Which might display better with long titles

The popover adapts to the length of the lines until a ceratin limit where it goes to next line.

Do you think perhaps it should say
This item is associated to <
for this language

No need imho to make the popover even more complex.

Maybe there are some blank lines then which are making it so high?

I get this here when there is a short title. No idea why you get it different.

<a href="/joomla-cms-staging/joomla-cms-staging/administrator/index.php?option=com_associations&amp;view=association&amp;layout=edit&amp;itemtype=com_content.article&amp;task=association.edit&amp;id=2&amp;target=af-ZA%3A12%3Aedit" title="" class="hasPopover label label-af" data-content="<br/><br/>test (2)<br /><br /><br/><br/>Edit association" data-placement="top" data-original-title="Afrikaans">AF</a>

Yes there are a lot of br there.

I have to edit line 203 and 249 to remove the br and get the view you showed

I get here

"<a class="hasPopover label label-fr" data-placement="top" data-content="Catégories en français<br /><br />Edit association" title="" href="/testwindows/trunkgitnew/administrator/index.php?option=com_associations&view=association&layout=edit&itemtype=com_content.category&task=association.edit&id=10&target=fr-FR%3A9%3Aedit" data-original-title="French">FR</a>
</li>```

because indeed on my test site I took off both br line 203 and 221 forgot to change this on my pr to you.
Leave alone the ones line 249 as they are necessary to create a blank between the title of the associated item and the Edit Association
will make new PR to your branch now

PR to solve this
brianteeman#4

I have tested this item ✅ successfully on 70a6134

Patch ok for me

@infograf768 I merged your pr#4 but it has created an error

0 syntax error, unexpected '';' (T_CONSTANT_ENCAPSED_STRING)

I am away from my computer so i cant check it on my phone

I have commented on the pr there is still a ' wich needs to be removed :)

yes, I know
please merge
brianteeman#5

also 2 cs

merged and checked on my phone and it seems ok now

I have tested this item ✅ successfully on 5009528

As @AlexRed tested before the bug with the ' and my tests are also fine, RTC.