I have tested this item ? unsuccessfully on 7efc54b

In none Tab a text2-Editor is shown.

I have tested this item ✅ successfully on 7efc54b

On Tab Options Editor Text2 is shown (first changes in xml-File got not saved).

@Fedik Can you fix the conflicts in your PR please?

I have tested this item ✅ successfully on 7efc54b

This fixes the editor buttons for when they are set to hidden in the form xml. It also fixes the issue #14935 for that case.
However both issues remain for the case where the editor is added using a custom editor field.

@Bakual conflict fixed

Looks like it works now also for the custom fields. Either your conflict solving or me changing some settings in my testing site fixed it.
All good now as far as I see.

I have tested this item ✅ successfully on 09b6ad3

Tested after conflict solving again.

I will test that pr tomorrow morning as well.

please remove RTC,
later I try to fis #14935 also, it is somehow related

Remove RTC as wanted by @Fedik

There are also merge conflicts now

There are also merge conflicts now

That's not true:

This branch has no conflicts with the base branch

Well the patch file doesnt apply, it rejects... https://patch-diff.githubusercontent.com/raw/joomla/joomla-cms/pull/14520.patch

There are also merge conflicts now

it is a last problem here ?

Please test now again.
+
Test these issues which also should be fixed: #14935 #14990

I have tested this item ✅ successfully on 96603d2

Tested both with my extension and a custom editor field.

• Show Button setting is now respected both in form.xml and custom field parameter
• Hide Button setting is now respected in both places as well and it also works when the parameter is empty
• Buttons work as expected.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14520.}

This fixes #14935 #14990

BUT - incoming, another bug for you to fix - will log it now. This PR can be improved to fix that next bug.

I have tested this item ✅ successfully on 96603d2

Thank you @Fedik

RTC

@PhilETaylor i think we can fix the other bug in a new PR. I'm merging this for now and we can fix the other bug with a new PR.

Thanks! ?

@PhilETaylor the code is not related to tinyMCE: https://github.com/joomla/joomla-cms/blob/staging/media/com_content/js/admin-article-readmore.js

``js
content = (new Function('return ' + options.editor))();

replace it with:
```js
if (window.parent.Joomla && window.parent.Joomla.editors && window.parent.Joomla.editors.instances && window.parent.Joomla.editors.instances.hasOwnProperty(editor)) {
			content = window.parent.Joomla.editors.instances[editor].getContent()
		} else {
			content = (new Function('return ' + options.editor))();
		}

Simple fix

Good work!

Would that mean we can have now different editors on the same page? Then we can think about a setting in the editor custom field to define which editor should be loaded.

Would that mean we can have now different editors on the same page? Then we can think about a setting in the editor custom field to define which editor should be loaded.

As I understood @dgt41, different editors on the same page work if all editor-xtd plugins are rewritten to the new format. It doesn't work for those using the old format (which will be a lot 3rd party ones). So for now I wouldn't add the option to specify the editor type. With 4.0 we can add it.

Would that mean we can have now different editors on the same page?

Not so soon :(
The problem is that all the existing editors (apart the core ones) are still using the old jInsertEditorText() which by design is not supporting multiple editors (different type).
On top of that as @Bakual wrote above all the XTDs are using as well the old method jInsertEditorText().

The only thing we could do is prepare all the plugins to use the new API if the editor supports it e.g.

if (window.parent.Joomla && window.parent.Joomla.editors && window.parent.Joomla.editors.instances && window.parent.Joomla.editors.instances.hasOwnProperty(editor)) {
	content = window.parent.Joomla.editors.instances[editor].getContent()
} else {
	content = (new Function('return ' + options.editor))();
}

Also there is another instance that needs to follow the API in /administarator/components/com_fields/view/fields/tmpl/modal.php
instead of

fieldIns = function(id) {
	window.parent.jInsertEditorText("{field " + id + "}", "' . $editor . '");
	window.parent.jModalClose();
};
fieldgroupIns = function(id) {
	window.parent.jInsertEditorText("{fieldgroup " + id + "}", "' . $editor . '");
	window.parent.jModalClose();
};

we should use

fieldIns = function(id) {
if (window.parent.Joomla && window.parent.Joomla.editors && window.parent.Joomla.editors.instances && window.parent.Joomla.editors.instances.hasOwnProperty(editor)) {
	window.parent.Joomla.editors.instances[editor].replaceSelection("{field " + id + "}")
} else {
	window.parent.jInsertEditorText("{field " + id + "}", "' . $editor . '");
}
	window.parent.jModalClose();
};
fieldgroupIns = function(id) {
if (window.parent.Joomla && window.parent.Joomla.editors && window.parent.Joomla.editors.instances && window.parent.Joomla.editors.instances.hasOwnProperty(editor)) {
        window.parent.Joomla.editors.instances[editor].replaceSelection("{fieldgroup " + id + "}")
} else {
	window.parent.jInsertEditorText("{fieldgroup " + id + "}", "' . $editor . '");
}
	window.parent.jModalClose();
};

@PhilETaylor if we apply these changes to read more and fields modal view then all core components are supporting multiple (different types) editors per page.
But all 3rd PD editors and XTDs will not if they don't update their code to use the API

ok then, someone needs to copy paste those code snippets and create the PRs