User tests: Successful: Unsuccessful:
Pull Request for Issue # .
<hr id="readmore"/>
Before applying this patch make sure that tinyMCE is your current editor and the drag and drop is enabled. Also make sure that page break button is placed in your toolbar.
Observe the bugs:
Apply the patch
Repeat the above steps and verify that tooltips are displaying correctly and page break produces the same code as read more!
Download a skin for tinymce e.g. https://github.com/dgt41/bootstrap-test/raw/gh-pages/editors.zip_.zip
Extract the skin and place it in:
administrator/templates/isis/css
and
templates/protostar/css
Visit the article form in back end and front end. Verify that the skin is loaded
The skin part needs to be documented somewhere in the templates docs.
For J4 the automation script for asset management needs to delete the page break plugin!
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings JavaScript External Library Front End Plugins |
Labels |
Added:
?
?
|
Fair enough
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-13 06:03:32 |
Closed_By | ⇒ | dgt41 |
Actually breaking this to 3 different PRs means that the 2 of them will need to be rebased as all of them are touching the same file tinymce.php
. I know it's a bit more work to test this but the procedure is well documented (at least I think so)
Status | Closed | ⇒ | New |
Closed_Date | 2017-03-13 06:03:32 | ⇒ | |
Closed_By | dgt41 | ⇒ |
Status | New | ⇒ | Pending |
Same file doesn't matter. You only get conflicts if the same line is changed.
Same file doesn't matter. You only get conflicts if the same line is changed.
Not really when using eclipse. It basically depends of the order of the changes.
If the order is changes descending the file, it is fine. If not, we get conflicts.
Parts of this are already merged, the rest will be done in separate PRs
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 21:35:35 |
Closed_By | ⇒ | dgt41 |
My 2c a PR should have a single task. This one has multiple - I would break it up into multiple PR. It will make it easier to test and manage. etc
3.. skins