? ? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
12 Mar 2017

Pull Request for Issue # .

Summary of Changes

  • This PR is patching a bug in tooltips misplacement after using drag and drop
  • It moves the drag and drop plugin out of the plugins directory (easier maintainability)
  • It removes the page break plugin that comes with tinyMCE and introduces a custom plugin that creates a Joomla compatible <hr id="readmore"/>
  • It also deprecates the option for selecting a skin and introduces an automatic skin selector using the current template. The theme should be bound to the template :)

Testing Instructions

Before applying this patch make sure that tinyMCE is your current editor and the drag and drop is enabled. Also make sure that page break button is placed in your toolbar.

Observe the bugs:

  • Drag and drop an image, after the image has been uploaded try hovering in any button in the toolbar, the tooltip is way off.
  • Click on the page break and the readmore buttons, check the produced code

Apply the patch

Repeat the above steps and verify that tooltips are displaying correctly and page break produces the same code as read more!

Download a skin for tinymce e.g. https://github.com/dgt41/bootstrap-test/raw/gh-pages/editors.zip_.zip
Extract the skin and place it in:
administrator/templates/isis/css
and
templates/protostar/css
Visit the article form in back end and front end. Verify that the skin is loaded

Documentation Changes Required

The skin part needs to be documented somewhere in the templates docs.

For J4 the automation script for asset management needs to delete the page break plugin!

9ff0a58 12 Mar 2017 avatar dgt41 init
avatar dgt41 dgt41 - open - 12 Mar 2017
avatar dgt41 dgt41 - change - 12 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2017
Category Administration Language & Strings JavaScript External Library Front End Plugins
4558d61 12 Mar 2017 avatar dgt41 CS
avatar dgt41 dgt41 - change - 12 Mar 2017
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 12 Mar 2017

My 2c a PR should have a single task. This one has multiple - I would break it up into multiple PR. It will make it easier to test and manage. etc

  1. Drag and Drop
  2. read more
    3.. skins
avatar dgt41
dgt41 - comment - 13 Mar 2017

Fair enough

avatar dgt41 dgt41 - change - 13 Mar 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-03-13 06:03:32
Closed_By dgt41
avatar dgt41 dgt41 - close - 13 Mar 2017
avatar dgt41
dgt41 - comment - 13 Mar 2017

Actually breaking this to 3 different PRs means that the 2 of them will need to be rebased as all of them are touching the same file tinymce.php. I know it's a bit more work to test this but the procedure is well documented (at least I think so)

avatar dgt41 dgt41 - change - 13 Mar 2017
Status Closed New
Closed_Date 2017-03-13 06:03:32
Closed_By dgt41
avatar dgt41 dgt41 - change - 13 Mar 2017
Status New Pending
avatar dgt41 dgt41 - reopen - 13 Mar 2017
avatar Bakual
Bakual - comment - 13 Mar 2017

Same file doesn't matter. You only get conflicts if the same line is changed.

avatar infograf768
infograf768 - comment - 13 Mar 2017

Same file doesn't matter. You only get conflicts if the same line is changed.

Not really when using eclipse. It basically depends of the order of the changes.
If the order is changes descending the file, it is fine. If not, we get conflicts.

avatar dgt41
dgt41 - comment - 24 May 2017

Parts of this are already merged, the rest will be done in separate PRs

avatar dgt41 dgt41 - change - 24 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-24 21:35:35
Closed_By dgt41
avatar dgt41 dgt41 - close - 24 May 2017

Add a Comment

Login with GitHub to post a comment