? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
11 Mar 2017

Pull Request for Issue #13873.

Summary of Changes

The user form field doesn't work on the front. Why is not part of this pr. This pr removes the option to define where the field to display.
image

Testing Instructions

  • Create a new user field.
  • Open the options tab.

Expected result

The "Show On" setting should not being displayed.

Actual result

The "Show On" setting is displayed.

Documentation Changes Required

avatar laoneo laoneo - open - 11 Mar 2017
avatar laoneo laoneo - change - 11 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2017
Category Front End Plugins
avatar brianteeman
brianteeman - comment - 11 Mar 2017

Thank you

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 11 Mar 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Mar 2017

I have tested this item ? unsuccessfully on 0d3897e

"Shown On" is shown at User- and Artices-Field (PR-Title ist about User, Screenshot about Articles).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

avatar laoneo
laoneo - comment - 12 Mar 2017

It's about the "User" custom field. Did you create a user custom field?

avatar PhilETaylor
PhilETaylor - comment - 12 Mar 2017

(#13873) Well it comes down to expectation and documentation - like most of com_fields, its inconsistent, has no defined structure or documented goals...

Therefore its hard to know if this is a bug, a feature, an oversight, or just plain wrong.

If only there were some documentation or design document, or ux team that could be consulted...

Someone needs to make a decision on what this fields purpose actually is!!!!

Then it should be documented.

and ONLY THEN should a PR be generated to fit the PURPOSE of the custom field.

At the moment this PR just masks a bigger design issue.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Mar 2017

@laoneo Created a New Field and Shown on is shown in Tab Options.

avatar laoneo
laoneo - comment - 12 Mar 2017

@franz-wohlkoenig Is it really a user field?
image

@PhilETaylor there is some documentation already https://docs.joomla.org/J3.x:Adding_custom_fields/User_Field. The purpose of the field is to select a user. It is not too much complicated.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Mar 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Mar 2017

I have tested this item successfully on 0d3897e

My brain told me till now "User Group" … sorry and thanks for hint, @laoneo


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

avatar mbabker
mbabker - comment - 12 Mar 2017

JFormFieldUser cannot be used on the frontend due to a hardcoded dependency in the layout to the com_users backend component (why the hell are library classes still hardcoded to depend on components!?). Until a proper proxy is in place for the support to happen, this PR is valid and should be merged.

Let's leave comments about architecture or design docs out of this for the moment.

avatar PhilETaylor
PhilETaylor - comment - 12 Mar 2017

So we are removing features, that are already documented, before even releasing....

Isn't the point of adding these new features because there is a need to show the user field on the frontend?

According to the documentation, it will still show on the frontend as text when viewing the item, but im guessing that then will not be editable on the frontend as an author?

It just seems that all this is afterthought, with not much thought.

avatar mbabker
mbabker - comment - 12 Mar 2017

You can either write the support for the frontend com_users component required to use JFormFieldUser in a frontend edit context (this limitation is not new to the addition of com_fields, all that did was further expose the architectural flaw) or you can remove from the UI a misleading and unusable option. The latter is a better choice unless someone has a PR for the former ready in the next couple of days. Even then, this PR could easily be reverted as part of that one.

avatar ysrostov
ysrostov - comment - 17 Mar 2017

If custom field is added in the backend with option "required", then adding any article in frontend at the moment (beta 3) becomes impossible because on submit we get en error message "Warning Field required: NameOfField"

avatar laoneo
laoneo - comment - 17 Mar 2017

@ysrostov can you please open a new issue for your problem. This will also happen when you set that setting to back end only and try to edit an article in the front. We need to decide what we should do in that situation. Thanks.

avatar ysrostov
ysrostov - comment - 17 Mar 2017

Sure thing
#14692

avatar normanmm normanmm - test_item - 23 Mar 2017 - Tested successfully
avatar normanmm
normanmm - comment - 23 Mar 2017

I have tested this item successfully on 0d3897e

Result is as expected


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

avatar jeckodevelopment jeckodevelopment - change - 23 Mar 2017
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 23 Mar 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

avatar PhilETaylor PhilETaylor - test_item - 27 Mar 2017 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 27 Mar 2017

I have tested this item successfully on 0d3897e

The user form field doesn't work on the front. Why is not part of this pr.

And as such it still doesnt show on the frontend for me @ joomla-cms/staging@ 0d3897e

This pr removes the option to define where the field to display.

It certainly did that ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14500.

avatar rdeutz rdeutz - change - 30 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-30 21:32:51
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 30 Mar 2017
avatar rdeutz rdeutz - merge - 30 Mar 2017

Add a Comment

Login with GitHub to post a comment