User tests: Successful: Unsuccessful:
Pull Request for Issue #13873.
The user form field doesn't work on the front. Why is not part of this pr. This pr removes the option to define where the field to display.
The "Show On" setting should not being displayed.
The "Show On" setting is displayed.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
I have tested this item
"Shown On" is shown at User- and Artices-Field (PR-Title ist about User, Screenshot about Articles).
It's about the "User" custom field. Did you create a user custom field?
(#13873) Well it comes down to expectation and documentation - like most of com_fields, its inconsistent, has no defined structure or documented goals...
Therefore its hard to know if this is a bug, a feature, an oversight, or just plain wrong.
If only there were some documentation or design document, or ux team that could be consulted...
Someone needs to make a decision on what this fields purpose actually is!!!!
Then it should be documented.
and ONLY THEN should a PR be generated to fit the PURPOSE of the custom field.
At the moment this PR just masks a bigger design issue.
@franz-wohlkoenig Is it really a user field?
@PhilETaylor there is some documentation already https://docs.joomla.org/J3.x:Adding_custom_fields/User_Field. The purpose of the field is to select a user. It is not too much complicated.
I have tested this item
My brain told me till now "User Group" … sorry and thanks for hint, @laoneo
JFormFieldUser
cannot be used on the frontend due to a hardcoded dependency in the layout to the com_users backend component (why the hell are library classes still hardcoded to depend on components!?). Until a proper proxy is in place for the support to happen, this PR is valid and should be merged.
Let's leave comments about architecture or design docs out of this for the moment.
So we are removing features, that are already documented, before even releasing....
Isn't the point of adding these new features because there is a need to show the user field on the frontend?
According to the documentation, it will still show on the frontend as text when viewing the item, but im guessing that then will not be editable on the frontend as an author?
It just seems that all this is afterthought, with not much thought.
You can either write the support for the frontend com_users component required to use JFormFieldUser
in a frontend edit context (this limitation is not new to the addition of com_fields, all that did was further expose the architectural flaw) or you can remove from the UI a misleading and unusable option. The latter is a better choice unless someone has a PR for the former ready in the next couple of days. Even then, this PR could easily be reverted as part of that one.
If custom field is added in the backend with option "required", then adding any article in frontend at the moment (beta 3) becomes impossible because on submit we get en error message "Warning Field required: NameOfField"
I have tested this item
Result is as expected
Status | Pending | ⇒ | Ready to Commit |
RTC
I have tested this item
The user form field doesn't work on the front. Why is not part of this pr.
And as such it still doesnt show on the frontend for me @ joomla-cms/staging@ 0d3897e
This pr removes the option to define where the field to display.
It certainly did that ...
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-30 21:32:51 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
Thank you