? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
11 Mar 2017

Pull Request for Issue #14497 .

Summary of Changes

Passing the item language to the stringURLSafe method in the field table

Testing Instructions

Save a field and check that the alias is sanitised as expected. In english there should be no change at all to the current behavior. In other languages transliteration may kick in depending on the field language (or site language) setting.

avatar Bakual Bakual - open - 11 Mar 2017
avatar Bakual Bakual - change - 11 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Mar 2017
Category Administration com_fields
avatar zero-24 zero-24 - alter_testresult - 11 Mar 2017 - humblehumanbeing: Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Apr 2017
Title
Properly sanitise "alias" in field
[com_fields] Properly sanitise "alias" in field
avatar joomla-cms-bot joomla-cms-bot - edited - 7 Apr 2017
avatar laoneo
laoneo - comment - 11 Apr 2017

Can you please adapt your change to the new name field. Thanks.

avatar zero-24 zero-24 - change - 11 Apr 2017
Labels Added: ?
2661254 11 Apr 2017 avatar zero-24 drone
avatar zero-24
zero-24 - comment - 11 Apr 2017

@laoneo @Bakual please check with the last changes

avatar laoneo
laoneo - comment - 11 Apr 2017

Thanks @zero-24, for me it looks fine now.

avatar rdeutz
rdeutz - comment - 17 Apr 2017

merged on review and because successful tests in the original issue

avatar rdeutz rdeutz - close - 17 Apr 2017
avatar rdeutz rdeutz - merge - 17 Apr 2017
avatar rdeutz rdeutz - change - 17 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-17 13:58:48
Closed_By rdeutz

Add a Comment

Login with GitHub to post a comment