[#14417] - Allow different buttons setup for tinyMCE
- Closed
- 12 Mar 2017
- Medium
- Build: staging
- # 14417
- Diff
- dgt41:tinyMCE_buttons
User tests: Successful: Unsuccessful:
Pull Request complimentary for Issue #14390 .
Summary of Changes
Pass different params for each instance of tinyMCE
Testing Instructions
-
In the global configuration select Tynimce as your default editor.
-
Create a new Editor custom field.
-
Select the Show Buttons as YES!
-
Select in the next input the buttons you want to hide.
-
Save the field.
-
Create a new article
-
Repeat the process but making Show Buttons as NO!
Expected result
Buttons behave according to the given input
Documentation Changes Required
This might not be B/C compatible (depending the tinyMCE introduced the Joomla.storageOptions)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript External Library Front End Plugins |
I couldn't find the PR for that, thanks for clearing this out
Is this ready for testing?
Yup
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.
I have tested this item
Works nicely.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.
shall rtc be removed?
yup, let's figure out another way for this
| Status | Ready to Commit | ⇒ | Pending |
back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14417.
Would be great if it will be possible, i ran into this today :)
| Labels |
Added:
?
|
||
@dgt41 could work, but still not perfect
did you seen, there already test for "whether default parameters loaded"?
I think here need something like:
// Load default:
if (empty($options['tinyMCE']['default'])) {
$options['tinyMCE']['default'] = array(/* default, general, params*/)
}
// Load changes for current name
$options['tinyMCE']['fieldName']['toolbar1'] = 'blabla';
I know
then you should note that adding if (!$this->defaultParamsLoaded) make no difference
but the other option needs a lot of refactoring and due to the legacy method is double work.
true, but current solution with _' . $id introduce more mess , I think
I try to check more, this weekend, if will get some time
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-12 13:32:48 |
| Closed_By | ⇒ | dgt41 |
As this was done in 3.7 this is not a problem right?