[#14389] - Update to jqiery mini colors 2.2.4
- Closed
- 31 Mar 2017
- Medium
- Build: staging
- # 14389
- Diff
- brianteeman:jquery-minicolors
User tests: Successful: Unsuccessful:
Updates the jQuery MiniColors library to the latest version (from 2.2.3 to 2.2.4)
Summary of Changes
Just applying latest patch version
Testing Instructions
Make sure the color field (eg color picker in the protostar template style) still works as expected.
Disclaimer
Work is done by @brianteeman
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
that means not good as is.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14389.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14389.
Ah I see, last time when the picker was updated the CSS was left original. Issue is that they rewrote the CSS for Bootstrap support somewhere around their version 2.1.0
When we revert the change in the CSS it works fine again.
So should I remove our hacks to the css?
We can either revert the CSS to the one in staging, which should work from what I saw.
Or we can try to copy the BS2 CSS rules into their current CSS and see how that works out. But that would mean hacking a 3rd party library to a degree.
I'm closing this PR as @brianteeman is now able to create his own PRs again
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-31 13:19:38 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 181c76b
it works but:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14389.