[#14351] - Fix typo
- Fixed in Code Base
- 9 Mar 2017
- Medium
- Build: staging
- # 14351
- Diff
- joomdonation:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The method JPath::check() https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filesystem/path.php#L165 only has one parameter but we are passing two parameters in the method call and it is wrong. This PR just fixes that typo.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
test instructions?
@infograf768 Since it changes one line of code in JViewLegacy, for human testing, try to access to articles list in backend, then add or edit an article, if it works, then the test could be marked as success
As I mentioned, the test can be done by code review. In the method code, we only have one parameter, but in method call, we are passing two parameters and it is clearly wrong. (If you use an IDE like phpstorm, it will complain about the error and you can easily see it).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14351.
@infograf768 RTC as there are 2 successfully Tests?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14351.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-09 14:48:28 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks everyone :)
I have tested this item✅ successfully on 75eea74
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14351.