?
avatar bertmert
bertmert
5 Mar 2017

Steps to reproduce the issue

  • Install current Staging (3.7.0).

  • See that all categories (com_content) are checked-in (not locked).

  • Module Manager > New > "Articles - Categories"

  • Enter Title

  • Field "Parent Category" > Click on button "Create" and create a new category > Save & close category

  • Save & close module.

  • Go to Category Manager (com_content): Newly created category is checked-out/locked

05-03-_2017_11-40-16

avatar bertmert bertmert - open - 5 Mar 2017
avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Mar 2017
avatar bertmert bertmert - edited - 5 Mar 2017
avatar bertmert bertmert - edited - 5 Mar 2017
avatar bertmert bertmert - change - 5 Mar 2017
The description was changed
avatar bertmert bertmert - edited - 5 Mar 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Mar 2017

Confirmed. Similar #14192

avatar bertmert
bertmert - comment - 6 Mar 2017

The issue is only present when I use button "Save & Close". Not when I first "Save" and then "Close".
With "Save & Close" I see for a short moment a nearly empty modal (no form, just headline) that closes. Afterwards I see just for a short moment that a new modal appears (complete edit form for created category).

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 6 Mar 2017

there are now 3 different Issues about locked Items created in Modal.

avatar bertmert
bertmert - comment - 7 Mar 2017

Any chance to get a "release-blocker" label then here or there? In a multi user Joomla there will be too many locked items that cannot be unlocked by some user groups.

avatar mbabker
mbabker - comment - 7 Mar 2017

While annoying, this does not constitute a release blocker IMO. If it were consistently reproducible every time someone used the feature, maybe. But as it seems to be limited to the use of one browser, its severity is downgraded massively.

avatar tonypartridge
tonypartridge - comment - 9 Mar 2017

@bertmert do you have any errors in your error logs that could help us pin point the issue?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Mar 2017

@tonypartridge Test new Article in Modal at Menu Item Type "Single Article":

  • Click Read-more-Button: TypeError: b is undefined. admin-article-readmore.min.js:1:160
  • Click Save-Button: Use of getAttributeNode() is deprecated. Use getAttribute() instead. jquery-migrate.min.js:2:1714
  • Click Save & Close-Button: TypeError: n.getComputedStyle(...) is null. tinymce.min.js

bildschirmfoto 2017-03-09 um 08 04 36

avatar infograf768
infograf768 - comment - 9 Mar 2017

I confirm the issue for all modals displayed after using a Create and it is consistent. (Firefox)
@Fedik @dgt41
This looks related to the modals themselves. The fact that the modal is limited to the buttons once using Save and Close is a totally new behavior. That aspect is also the case for Safari, although Safari does not save the item as locked.

avatar infograf768
infograf768 - comment - 9 Mar 2017

@mbabker
We have the same issue when Edting an existing category or article through the modal, etc, not only when creating.
It's quite serious.

avatar dgt41
dgt41 - comment - 9 Mar 2017

The modal approach has a few problems:

  • tinyMCE sets up a listener for form submit, this is not removed when the modal is closed
  • This could be true for any script that's loaded in the iframe
  • the code is a bit weird for me:
				// For Save & Close (save task) when creating we need to replace the task as apply because of redirects after submit and hide the iframe.
				if (task === 'save')
				{
					submittedTask = 'apply';
					jQuery('#' + modalId + ' iframe').addClass('hidden');
				}

				document.getElementById('Frame_' + modalId).contentWindow.Joomla.submitbutton(itemType.toLowerCase() + '.' + submittedTask);

So to prevent the redirect you have this odd behaviour...

avatar infograf768
infograf768 - comment - 9 Mar 2017

I think we HAVE to solve this in 3.7.0. It's really bad.

avatar tonypartridge
tonypartridge - comment - 9 Mar 2017

I agree with @infograf768 it's a UX pain and can come across as buggy from an end users perspective.

avatar Fedik
Fedik - comment - 12 Mar 2017

please test #14537

avatar bertmert
bertmert - comment - 12 Mar 2017

Closed as we have a PR

avatar bertmert bertmert - change - 12 Mar 2017
The description was changed
Title
[3.7.0] mod_articles_categories. Newly created category stays checked-in/locked
[3.7.0] mod_articles_categories. Newly created category stays checked-out/locked
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-03-12 16:01:44
Closed_By bertmert
avatar bertmert bertmert - close - 12 Mar 2017

Add a Comment

Login with GitHub to post a comment