? ?

Pending

User tests: Successful: Unsuccessful:

avatar yvesh
yvesh
4 Mar 2017

Summary of Changes

When you batch copy items the hits counter (if there is one) is not reseted. This PR prevents overriding the method for just a one line code change.

Testing Instructions

Test if after duplication the hits of duplicated items (which support hits and are not overriding the method!) are set to zero.

Expected result

Hits are reset to zero after duplication

Actual result

Hits are currently the same as the item copied from..

Documentation Changes Required

None

avatar yvesh yvesh - open - 4 Mar 2017
avatar yvesh yvesh - change - 4 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2017
Category Libraries
avatar yvesh yvesh - change - 4 Mar 2017
Title
Reset Hits in batch copying if existing
Reset Hits in batch copying if column exists
avatar yvesh yvesh - edited - 4 Mar 2017
avatar yvesh yvesh - change - 4 Mar 2017
The description was changed
avatar yvesh yvesh - edited - 4 Mar 2017
avatar yvesh yvesh - change - 4 Mar 2017
The description was changed
avatar yvesh yvesh - edited - 4 Mar 2017
avatar zero-24 zero-24 - test_item - 4 Mar 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 4 Mar 2017

I have tested this item successfully on b252e18

works good here. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14325.

avatar chmst chmst - test_item - 4 Mar 2017 - Tested successfully
avatar chmst
chmst - comment - 4 Mar 2017

I have tested this item successfully on b252e18

I've tested this item successfully on the latest version of weblinks. On articles the reset of hitcounters worked already before the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14325.

avatar zero-24 zero-24 - change - 4 Mar 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ? ?
avatar zero-24
zero-24 - comment - 4 Mar 2017

RTC Thanks @yvesh and @chmst


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14325.

avatar wilsonge
wilsonge - comment - 4 Mar 2017

@yvesh please can we use JTable getColumnAlias for the hits column name please!

avatar yvesh
yvesh - comment - 4 Mar 2017

@wilsonge you mean:

			$hitsAlias = $this->table->getColumnAlias('hits');

			if (isset($this->table->$hitsAlias))
			{
				$this->table->$hitsAlias = 0;
			}
avatar wilsonge
wilsonge - comment - 4 Mar 2017

Yes :)

avatar yvesh yvesh - change - 4 Mar 2017
Labels
avatar wilsonge wilsonge - change - 4 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-04 17:26:02
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Mar 2017
avatar wilsonge wilsonge - merge - 4 Mar 2017

Add a Comment

Login with GitHub to post a comment