Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#14309] - Removing the gallery field plugin from core

? ? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
2 Mar 2017

As it seems that we can't really make this plugin useful as is or as proposed in #14238

Here is a PR to remove it entirely from core.

Please verify that I have not forgotten anything.

@rdeutz @dgt41 @laoneo @Bakual

avatar infograf768 infograf768 - open - 2 Mar 2017
avatar infograf768 infograf768 - change - 2 Mar 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2017
Category ⇒ Administration com_admin SQL Postgresql MS SQL Language & Strings Installation Front End Plugins
avatar zero-24
zero-24 - comment - 2 Mar 2017

Language files?

avatar infograf768
infograf768 - comment - 2 Mar 2017

yep, will update tomorrow

avatar infograf768 infograf768 - change - 3 Mar 2017
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 3 Mar 2017

Done.

avatar dgt41 dgt41 - test_item - 3 Mar 2017 - Tested successfully
avatar dgt41
dgt41 - comment - 3 Mar 2017

I have tested this item ✅ successfully on 7b4cdd5

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14309.

avatar laoneo
laoneo - comment - 3 Mar 2017

The js and CSS files should also be deleted from here https://github.com/joomla/joomla-cms/tree/staging/media/plg_fields_gallery

avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2017
Category Administration com_admin SQL Postgresql MS SQL Language & Strings Installation Front End Plugins ⇒ Administration com_admin SQL Postgresql MS SQL Language & Strings Installation JavaScript Front End Plugins
avatar infograf768
infograf768 - comment - 3 Mar 2017

Done.

avatar shivamdiehard shivamdiehard - test_item - 3 Mar 2017 - Tested successfully
avatar shivamdiehard
shivamdiehard - comment - 3 Mar 2017

I have tested this item ✅ successfully on 8101a71

After applying the patch the gallery field plugin exists no more.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14309.

avatar infograf768
infograf768 - comment - 3 Mar 2017

@rdeutz
Looks like OK now. We just need a decision from you on this.

avatar shivamdiehard
shivamdiehard - comment - 3 Mar 2017

Was this issue related to only code review.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14309.

avatar infograf768
infograf768 - comment - 3 Mar 2017

Was this issue related to only code review.

Indeed, and also approving the remove taking into account the issues and poor usability.

avatar laoneo laoneo - test_item - 3 Mar 2017 - Tested successfully
avatar laoneo
laoneo - comment - 3 Mar 2017

I have tested this item ✅ successfully on 1928c2b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14309.

avatar infograf768 infograf768 - change - 3 Mar 2017
Status Pending ⇒ Ready to Commit
avatar infograf768 infograf768 - alter_testresult - 4 Mar 2017 - dgt41: Tested successfully
avatar infograf768
infograf768 - comment - 4 Mar 2017

RTC as all aspects of the removal are now taken care of.

Thanks all. We now wait for PLT final decision.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14309.

avatar rdeutz rdeutz - change - 4 Mar 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-03-04 07:55:46
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 4 Mar 2017
avatar rdeutz rdeutz - merge - 4 Mar 2017

Add a Comment

Login with GitHub to post a comment