? Pending

User tests: Successful: Unsuccessful:

avatar degobbis
degobbis
22 Feb 2017

Summary of Changes

Some changes for use width with independend class on invalid fields.

JHtml::_('behavior.formvalidation'); set class 'invalid' on requested empty fields
JHtml::_('behavior.formvalidation', 'uk-form-danger'); set class ''uk-form-danger' on requested empty fields

ping @dgt41

avatar degobbis degobbis - open - 22 Feb 2017
avatar degobbis degobbis - change - 22 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2017
Category Libraries JavaScript
avatar degobbis degobbis - change - 22 Feb 2017
The description was changed
avatar degobbis degobbis - edited - 22 Feb 2017
avatar yvesh
yvesh - comment - 22 Feb 2017

Ping @dgt41

avatar degobbis degobbis - change - 22 Feb 2017
Labels Added: ?
fda0ed8 22 Feb 2017 avatar degobbis fix
avatar dgt41
dgt41 - comment - 22 Feb 2017

@degobbis Please don't add a flag for the error class. You can achieve the same goal by copying the javascript files from /media/system to your templates/template-name/js and change the classes directly in the script (that's the reason Joomla has overrides)

avatar degobbis
degobbis - comment - 22 Feb 2017

@dgt41 In my opinion the template developer is not responsible for the form validation and the normal user should not deal with it. As a developer of a form extension, I try to render the outputs for all frameworks. Because it makes sense to pass the appropriate classes for the validation. In the end, it makes the lives of the developers easier.

avatar mbabker
mbabker - comment - 22 Feb 2017

This is supposed to be a framework agnostic helper. So adding hooks for framework specific things seems like a step backwards.

avatar degobbis
degobbis - comment - 22 Feb 2017

I do not understand your argument. To use a hard-coded class, which is not used in any current framework, I consider to be a step backwards. With this change I hope to integrate the same flexibility as has already happened with Modal.

avatar SniperSister
SniperSister - comment - 22 Feb 2017

I don't think that this is the right approach @degobbis - as mentioned in our Glip chat, you are trying to let extension devs fix what template devs broke. As a template dev, I should make sure that my template has the necessary stuff (=overrides or CSS) to make the generated markup look right - if I fail, it's my fault and not the extensions devs task to fix this.

avatar degobbis
degobbis - comment - 22 Feb 2017

@SniperSister You are not wrong, but unfortunately this lack falls back on the developer. It was worth a try.

avatar degobbis degobbis - change - 22 Feb 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-02-22 15:12:52
Closed_By degobbis
avatar degobbis degobbis - close - 22 Feb 2017

Add a Comment

Login with GitHub to post a comment