User tests: Successful: Unsuccessful:
Some changes for use width with independend class on invalid fields.
JHtml::_('behavior.formvalidation');
set class 'invalid' on requested empty fields
JHtml::_('behavior.formvalidation', 'uk-form-danger');
set class ''uk-form-danger' on requested empty fields
ping @dgt41
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries JavaScript |
Labels |
Added:
?
|
@dgt41 In my opinion the template developer is not responsible for the form validation and the normal user should not deal with it. As a developer of a form extension, I try to render the outputs for all frameworks. Because it makes sense to pass the appropriate classes for the validation. In the end, it makes the lives of the developers easier.
This is supposed to be a framework agnostic helper. So adding hooks for framework specific things seems like a step backwards.
I do not understand your argument. To use a hard-coded class, which is not used in any current framework, I consider to be a step backwards. With this change I hope to integrate the same flexibility as has already happened with Modal.
I don't think that this is the right approach @degobbis - as mentioned in our Glip chat, you are trying to let extension devs fix what template devs broke. As a template dev, I should make sure that my template has the necessary stuff (=overrides or CSS) to make the generated markup look right - if I fail, it's my fault and not the extensions devs task to fix this.
@SniperSister You are not wrong, but unfortunately this lack falls back on the developer. It was worth a try.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-22 15:12:52 |
Closed_By | ⇒ | degobbis |
Ping @dgt41