Feeling Lucky
?
?
[#14113] - Sync columns in contact_details table, add missing defaults, clean up
- Fixed in Code Base
- 19 Feb 2017
- Medium
- Build: staging
- # 14113
- Diff
- csthomas:mscontdb1
User tests: Successful: Unsuccessful:
Pull Request for issue #13289
To help #7680 on mssql
Summary of Changes
- Add missing defaults for columns [all db]:
- xreference
- sortname1, sortname2, sortname3
metakey, metadesc- column type TEXT can not have default value for mysql
- Add missing default for sqlsrv only:
- checked_out
- created_by_alias
- published
- Remove defaults because that columns can not have default '' for :
- name
- alias
- language # for postgresql only
-
Remove
DEFAULT NULLor aloneNULLfrom sql files because this is redundant. -
Clean up for postgresql:
ReplaceDEFAULT 0 NOT NULLtoNOT NULL DEFAULT 0
Info:
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/postgresql/joomla.sql#L264
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L287
Testing Instructions
Install joomla with applied changes.
Installation should pass on all databases.
Test create contact.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | MS SQL SQL Installation |
| Labels |
Added:
?
|
||
| Category | MS SQL SQL Installation | ⇒ | SQL Installation Postgresql MS SQL |
| Title |
|
||||||
| Category | MS SQL SQL Installation Postgresql | ⇒ | SQL Administration com_admin Postgresql MS SQL Installation |
waader
- comment
- 19 Feb 2017
I have tested this item
I tested postgresql and mssql.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14113.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels | |||
csthomas
- comment
- 19 Feb 2017
It is OK
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-19 19:52:09 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 308e1d3
Installation works well. Contacts can be created both on com_contact component and User - Contact Creator plugin
Please note that I only tested it on MySQL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14113.