[#14112] - Fix contact creator plugin
- Fixed in Code Base
- 19 Feb 2017
- Medium
- Build: 4.0-dev
- # 14112
- Diff
- wilsonge:fix-14090
User tests: Successful: Unsuccessful:
Pull Request for Issue #14090 .
Summary of Changes
Fixes the contact creation plugin
Testing Instructions
Test contact creation now works (note you may have to apply #13956 to fix a fields related problem on saving a user)
Expected result
Contact now saves
@alikon or @csthomas - Should some of these fields (like sortname1) be optional default null fields instead of some of this??
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Front End Plugins |
Do you think those fields should be optional? Even in the installation defaults we don't have values for all except the first contact :(
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14112.
@franz-wohlkoenig You need to apply PR #13956 too before testing. That issue you are having now was sorted by that PR
@joomdonation #13956 is merged, not available on Patchtester. Will install nightly-builds?
Install nightly-builds? might help. Or you can just replace the file plugins/system/fields/fields.php on your Joomla 4.0 installation with the content of this file https://github.com/joomla/joomla-cms/blob/4.0-dev/plugins/system/fields/fields.php
@joomdonation installed nightly-builds and later content of file fields.php, got after Save of existing User:
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14112.
I have tested this item
Since the fields sortname1, sortname2, sortname3 are not required, I think it would be better if we allow null or set default value like how we do with other fields address, suburb, state... instead of having to write code to set empty value for the fields like this
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14112.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
About related my PR. I could not add default value to meta... columns because they use TEXT type on mysql.
For sortname1,2,3 I have added default value.
| Status | Ready to Commit | ⇒ | Needs Review |
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14112.
I have tested it on j37 with enabled sql_mode from Joomla 4.0
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14112.
| Status | Needs Review | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14112.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-19 22:41:35 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I can not find any source which can explain that.
If this field is optional then sql table should have "DEFAULT ''" but for
sortname1I do not see it.In general there is a mess with defaults.
For me your changes are OK.