Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#14093] - Plugin System - Redirect - Display error 404 instead 500 when page does not exist [postgresql, sqlsrv]

? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
15 Feb 2017

Pull Request for Issue #13262 (comment)

Summary of Changes

In table #__redirect_links column comment does not have a default value.

On J4 mysql error should be visible.
On postgresql and sqlsrv error exists.

Testing Instructions

Install fresh joomla staging on postgresql or sqlsrv database.
Enable System - Redirect plugin
Go to not exists page like "index.php?option=sdfsdf"

Before patch:
Error 500 PLG_SYSTEM_REDIRECT_ERROR_UPDATING_DATABASE
After patch:
Error 404

Expected result

ERROR 404

Actual result

ERROR 500

Documentation Changes Required

None

avatar csthomas csthomas - open - 15 Feb 2017
avatar csthomas csthomas - change - 15 Feb 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2017
Category ⇒ SQL Administration com_admin Postgresql MS SQL Installation
avatar csthomas csthomas - change - 16 Feb 2017
Title
…
Error 500 instead 404 when plugin System - Redirect enabled [postgresql, sqlsrv]
Plugin System - Redirect - Display error 404 instead 500 when page does not exist [postgresql, sqlsrv]
avatar csthomas csthomas - edited - 16 Feb 2017
avatar csthomas csthomas - change - 16 Feb 2017
The description was changed
avatar csthomas csthomas - edited - 16 Feb 2017
avatar waader
waader - comment - 19 Feb 2017

Works for mssql. For postgresql it works when I change the line to
"comment" varchar(255) DEFAULT '' NOT NULL,

avatar csthomas
csthomas - comment - 19 Feb 2017

I will fix it in a few moments

I have found that on 9.0 and older postgresql syntax is a little different:
https://www.postgresql.org/docs/9.0/static/sql-createtable.html
https://www.postgresql.org/docs/9.1/static/sql-createtable.html

avatar csthomas csthomas - change - 19 Feb 2017
Labels Added: ?
avatar waader waader - test_item - 19 Feb 2017 - Tested successfully
avatar waader
waader - comment - 19 Feb 2017

I have tested this item ✅ successfully on cb4e027

Before the last change I got an installation error. Now it works fine. As I get no other errors everythings seems ok, at least at my side.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14093.

avatar wilsonge wilsonge - change - 22 Feb 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-02-22 10:39:46
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 22 Feb 2017
avatar wilsonge wilsonge - merge - 22 Feb 2017

Add a Comment

Login with GitHub to post a comment