Feeling Lucky
?
?
[#14026] - [com_tags] - remove warning from countTagItems()
- Fixed in Code Base
- 15 Feb 2017
- Medium
- Build: staging
- # 14026
- Diff
- alikon:patch-85
User tests: Successful: Unsuccessful:
Testing Instructions
- multilanguage
- php 7.1.1
go to com_tags and click on search tools and filter for tag type (article for example)
Expected result
no warning
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration |
jeckodevelopment
- comment
- 11 Feb 2017
@franz-wohlkoenig is it a successful test?
joomdonation
- comment
- 12 Feb 2017
@alikon According to PHP manual http://fr2.php.net/manual/en/function.call-user-func.php , to pass parameters by reference, you can use call_user_func_array instead
So maybe the code could be changed to
call_user_func_array(array($cName, 'countTagItems'), array(&$items, $extension));
tuts-22
- comment
- 13 Feb 2017
I have tested this item
The code works perfectly fine!!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14026.
alikon
- comment
- 13 Feb 2017
@joomdonation $cName::countTagItems($items, $extension); seems more readable to me
franz-wohlkoenig
- comment
- 14 Feb 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14026.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-15 19:13:55 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
Confirmed (mamp)