Feeling Lucky
?
[#14025] - com_contact, single contact. Remove nl2br where not needed
- Fixed in Code Base
- 13 Feb 2017
- Medium
- Build: staging
- # 14025
- Diff
- bertmert:patch-4
User tests: Successful: Unsuccessful:
Summary of Changes
- Removed useless nl2br() for text fields
contact->telephone
contact->fax
contact->mobile
Testing Instructions
-
Code review and/or
-
Create a contact entry.
-
Fill also fields telephone, fax and mobile. See that these are text fields (1 line), not textareas with multilines.
-
In tab Display set fields above to Show.
-
Create a menu item for this single contact.
-
Open menu item in frontend.
-
Compare output of fields above before and after patch. Nothing has changed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
joomdonation
- comment
- 12 Feb 2017
I have tested this item
Agree. nl2br is not needed for text fields like these fields.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14025.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 12 Feb 2017
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14025.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-13 18:17:42 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 50b2b53
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14025.