[#14017] - build/build.php $release has non-numeric value
- Closed
- 21 May 2017
- Medium
- Build: staging
- # 14017
When building Joomla in my branch derived from staging, I'm getting a notice that complains about the contents of $release.
Perhaps my php7.1 isn't set up quite like it should be for Joomla, or I have misunderstood the purpose of the $release variable. The notice I'm getting is:
Notice: A non well formed numeric value encountered in /home/user/Downloads/Joomla/joomla-cms/build/build.php on line 138
My Line 138 is:
for ($num = $release - 1; $num >= 0; $num--)
The build continues, but I'm not sure what the value should be here because when I echo $release, it contains the string 0-beta3. Should it be 0 or 3, or something else in certain cases? During my build, the string is evaluated to 0 and the for loop is bypassed.
| Labels |
Added:
?
|
||
@PhilETaylor : Right. Should I (or you) close this issue then?
| Category | ⇒ | Installation |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-05 11:05:31 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/14017
closed as this Issue is not an Core-Issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14017.
It is a core issue. The build script lives in the repository and is how we build release packages. So someone needs to confirm the build script works correctly on PHP 7.1 and if not fix it.
| Status | Closed | ⇒ | Needs Review |
| Closed_Date | 2017-04-05 11:05:31 | ⇒ | |
| Closed_By | franz-wohlkoenig | ⇒ |
Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/14017
i can confirm that the build script is NOT working correctly on php 7.1.1 so someone with better skills than me needs to fix it ;)
We probably need to restructure our internal constants in JVersion so they are always consistently strings or integers, not mixed. The way Symfony does it, each of their version constants in the Kernel is a fragment of the full version string, then they have a constant which is the full version string. https://github.com/symfony/http-kernel/blob/3.4/Kernel.php#L64-L69
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-21 15:34:27 |
| Closed_By | ⇒ | brianteeman |
This is a PHP 7.1 issue...
See other issues:
#12311
#13251
#12310