? Pending

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
9 Feb 2017

Pull Request for Issue # .

Summary of Changes

Enhance public function setMetaData() to allow setting og metas
For infos on og metas check: http://ogp.me

Testing Instructions

Apply the patch with patch tester
edit index.php on isis template and add

$this->setMetaData(
	array(
		"property" => "og:title",
		"content" => "The Rock"
	), '', ''
);
$this->setMetaData(
	array(
		"property" => "og:type",
		"content" => "video.movie"
	), '', ''
);

$this->setMetaData(
	array(
		"property" => "og:url",
		"content" => "http://www.imdb.com/title/tt0117500/"
	), '', ''
);

just before

?>
<!DOCTYPE html>

Inspect the rendered page through your browsers developers tools

Preview

screen shot 2017-02-09 at 19 45 36

Documentation Changes Required


This change is Reviewable

avatar dgt41 dgt41 - open - 9 Feb 2017
avatar dgt41 dgt41 - change - 9 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2017
Category Libraries
avatar dgt41 dgt41 - change - 9 Feb 2017
The description was changed
avatar dgt41 dgt41 - edited - 9 Feb 2017
avatar mbabker
mbabker - comment - 9 Feb 2017

Is there something you can't do with the current API? In the joomla.org template we're doing this and it works fine:

$this->setMetaData('og:site_name', $sitename, 'property');
avatar dgt41 dgt41 - change - 9 Feb 2017
Labels Added: ?
avatar dgt41
dgt41 - comment - 9 Feb 2017

Damn, I haven't tried that ?

avatar dgt41 dgt41 - change - 9 Feb 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-02-09 18:10:00
Closed_By dgt41
avatar dgt41 dgt41 - close - 9 Feb 2017

Add a Comment

Login with GitHub to post a comment