? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
9 Feb 2017

Pull Request for Issue # .

Summary of Changes

In HTML5, the backslash is not required on void elements, so this PR remove them from:

  • <img />
  • <br />
  • <hr />
  • <meta />
  • <base />
  • <link />
avatar C-Lodder C-Lodder - open - 9 Feb 2017
avatar C-Lodder C-Lodder - change - 9 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2017
Category Administration com_admin com_installer com_joomlaupdate com_media com_menus com_modules com_templates com_users Language & Strings
avatar C-Lodder C-Lodder - change - 9 Feb 2017
The description was changed
Title
[J4.0] remove backslash from <hr>, <img> and <br>
[J4.0] remove backslash from , and
avatar C-Lodder C-Lodder - edited - 9 Feb 2017
avatar RonakParmar
RonakParmar - comment - 10 Feb 2017

Done code review and found "No newline at end of file".

administrator/language/en-GB/en-GB.com_weblinks.ini
administrator/language/en-GB/en-GB.plg_authentication_gmail.ini
administrator/language/en-GB/en-GB.plg_authentication_joomla.ini
administrator/language/en-GB/en-GB.plg_authentication_joomla.sys.ini
administrator/language/en-GB/en-GB.plg_system_sef.ini


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14000.
avatar C-Lodder C-Lodder - change - 10 Feb 2017
Labels Added: ? ?
avatar C-Lodder
C-Lodder - comment - 10 Feb 2017

@RonakParmar - Thanks. Fixed

avatar C-Lodder C-Lodder - edited - 10 Feb 2017
avatar C-Lodder C-Lodder - change - 10 Feb 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 10 Feb 2017
avatar C-Lodder C-Lodder - change - 10 Feb 2017
Title
[J4.0] remove backslash from , and
[J4.0] remove backslash from void tags
avatar C-Lodder C-Lodder - change - 10 Feb 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 10 Feb 2017
avatar ciar4n
ciar4n - comment - 15 Feb 2017

I have tested this item successfully on c5b083c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14000.

avatar ciar4n ciar4n - test_item - 15 Feb 2017 - Tested successfully
avatar yvesh
yvesh - comment - 17 Feb 2017

I have tested this item successfully on c5b083c

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14000.

avatar yvesh yvesh - test_item - 17 Feb 2017 - Tested successfully
avatar wilsonge
wilsonge - comment - 17 Feb 2017

If you revert the phpmailer change I'm happy with this

avatar C-Lodder
C-Lodder - comment - 17 Feb 2017

@wilsonge - installation languages done and phpmailer reverted

avatar wilsonge wilsonge - change - 17 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-17 15:36:12
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Feb 2017
avatar wilsonge wilsonge - merge - 17 Feb 2017
avatar wilsonge
wilsonge - comment - 17 Feb 2017

Nice job :)

Add a Comment

Login with GitHub to post a comment