[#13941] - [AppVeyor] Unit tests fix for file cache
- Fixed in Code Base
- 8 Feb 2017
- Medium
- Build: staging
- # 13941
- Diff
- csthomas:fixcacheappveyor
User tests: Successful: Unsuccessful:
Summary of Changes
Fix unit test in cache tests.
Change file cache handler methods get and store to work on Windows system too.
On Windows system flock works different. It locks other methods from read/write on the same file in the same process.
Example:
$f = fopen('filename.txt', 'rb');
flock($f, LOCK_EX|LOCK_NB);
$content = stream_get_contents($f);
$content2 = file_get_contents('filename.txt'); // <- on Windows it will fail, but on linux it works
See http://php.net/manual/en/function.flock.php
flock() uses mandatory locking instead of advisory locking on Windows.
Testing Instructions
Code review
or standard test to check whether joomla create cache files.
Cache should works as before on linux system.
On windows it start to work after patch applied.
Expected result
App veyor success with cache tests
Actual result
App veyor failed with cache tests
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-08 09:34:50 |
| Closed_By | ⇒ | wilsonge |
I'm going to merge this on review as it fixes unit tests
@mbabker Can you take a look?