[#13940] - Ui Input Adjustment
- Closed
- 25 May 2017
- Medium
- Build: staging
- # 13940
- Diff
- cpfeifer:UIInputadjustment
User tests: Successful: Unsuccessful:
Pull Request for Issue #13862
Summary of Changes
Minor CSS Adjustments which define input widths in the right sidebar of editing screens to provide a more consistent appearance.
Specifically:
Tag Select Input, Version Text Input and Version Note Text Input
Found in editor interface for various components.
Publish & Unpublish Date Select Inputs
Found in Module editor interface.
Testing Instructions
Enter item editing screen in the following components:
Articles, Categories, Menu Items, Banners, Contacts, News Feeds, Tags, Modules
This PR adjusts Note, Version Note, Tags, and Publish / Unpublish inputs. If there are other inputs with issues please let me know and I will make further adjustments.
Expected result
All parameter options found on the right side should be the same width in all components.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
If the note input is going to be made that small, it should be changed to a textarea. A note could potentially be a small paragraph, so using a small input seems pointless.
I don't disagree, but the issue in question was that the text inputs were hanging off to the right side. This is a minor detail in my opinion and I could go either way on it.
So rather than changing the width just to make it blend in, why don't we do the right thing and use the correct element? Will need a simple tweak in the XML file.
I can do that. I didn't mess with the input types at all but that makes a lot sense.
I have tested the request and it works fine
I'll update this PR this week with the field types, it's a busy week for me.
@cpfeifer it has been several months since you said you would be updating this PR. It now has multiple conflicts which also need resolving. If this isnt updated it will be closed in a few weeks time as there is no point in keeping an abandoned and non mergeable PR open. Thanks
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-25 17:01:28 |
| Closed_By | ⇒ | cpfeifer | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 50f0276
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13940.