? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
4 Feb 2017

Pull Request for Issue #13008

Summary of Changes

Within Joomla, the RSS feed's lastBuildDate element uses the current timestamp without a way for the timestamp to be set to a value which follows specification. JDocumentFeed::$lastBuildDate can be used for this purpose. However, right now the field is declared as a string and the renderer uses a JDate object.

This PR proposes a B/C break changing JDocumentFeed::$lastBuildDate to be a JDate object versus a string and changes the renderer to use this property instead of the hardcoded behavior that exists now.

Testing Instructions

From a feed view, a developer should be able to set JDocumentFeed::$lastBuildDate to a JDate object with a timestamp of their choosing and the feed renderer use this value for the lastBuildDate element.

Documentation Changes Required

Note the B/C breaking change with the JDocumentFeed::$lastBuildDate property.

avatar mbabker mbabker - open - 4 Feb 2017
avatar mbabker mbabker - change - 4 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Feb 2017
Category Libraries
avatar mbabker mbabker - change - 4 Feb 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 4 Feb 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-04 23:08:27
Closed_By wilsonge
avatar wilsonge wilsonge - close - 4 Feb 2017
avatar wilsonge wilsonge - merge - 4 Feb 2017
avatar wilsonge
wilsonge - comment - 21 May 2017

This has caused Timezone being undefined for the published date in the RSS feed. This was fixed with 813f69f

Add a Comment

Login with GitHub to post a comment