[#13919] - Create an Exception for a missing component
- Fixed in Code Base
- 5 Feb 2017
- Medium
- Build: staging
- # 13919
- Diff
- mbabker:missing-component-exception
User tests: Successful: Unsuccessful:
Summary of Changes
The base Exception class really shouldn't be thrown, it's too generic and gets caught by too many try/catch blocks. Good practice is to use more specialized exceptions.
In JComponentHelper::renderComponent() an Exception is thrown if the component is missing (either the option parameter is empty, the component is disabled, or the entry point file doesn't exist in the filesystem). I've created a new JComponentExceptionMissing class to represent this error state instead.
Testing Instructions
A request for a non-existing or disabled component should result in a JComponentExceptionMissing object being thrown versus the base level Exception.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I think we should make the default code of the exception should be 404 if it's a component missing
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-05 17:38:19 |
| Closed_By | ⇒ | wilsonge |
Looks good now :)
I have tested this item✅ successfully on 267b142
Work as expected.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13919.